Skip to content

crypto: fix error when getRandomValues is called without arguments#45854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
panva wants to merge 1 commit into from
Closed

crypto: fix error when getRandomValues is called without arguments #45854

panva wants to merge 1 commit into from

Conversation

@panva
Copy link
Member

@panvapanva commented Dec 14, 2022

Fixes globalThis.crypto.getRandomValues arguments length validation.

Was

DOMException [TypeMismatchError]: The data argument must be an integer-type TypedArray

Now

Uncaught TypeError [ERR_MISSING_ARGS]: The "typedArray" argument must be specified code: 'ERR_MISSING_ARGS'

@panvapanva added crypto Issues and PRs related to the crypto subsystem. webcrypto labels Dec 14, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 14, 2022

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 14, 2022
@panvapanva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 14, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 15, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48500/

@panvapanva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2022
@panva
Copy link
MemberAuthor

panva commented Dec 16, 2022

Landed in 3014c5d

@panvapanva closed this Dec 16, 2022
panva added a commit that referenced this pull request Dec 16, 2022
@panva
crypto: fix error when getRandomValues is called without arguments
3014c5d
PR-URL: #45854 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@panvapanva deleted the fix-getrandomvalues-empty-args branch December 16, 2022 13:12
@aduh95
Copy link
Contributor

aduh95 commented Dec 16, 2022•
edited
Loading

This landed despite the latest Jenkins CI being red (and this change does affect the node binary).

node/doc/contributing/collaborator-guide.md

Lines 207 to 211 in 6831e2f

Do not land any pull requests without the necessary passing CI runs.
A passing (green) GitHub Actions CI result is required. A passing (green or
yellow) [Jenkins CI](https://ci.nodejs.org/) is also required if the pull
request contains changes that will affect the `node` binary. This is because
GitHub Actions CI does not cover all the environments supported by Node.js.

This was referenced Dec 17, 2022
Open
Open
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
@panva@targos
crypto: fix error when getRandomValues is called without arguments
c980286
PR-URL: #45854 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@panva@juanarbol
crypto: fix error when getRandomValues is called without arguments
c643645
PR-URL: #45854 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@juanarboljuanarbol mentioned this pull request Jan 28, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@anonriganonriganonrig approved these changes

@tniessentniessentniessen approved these changes

@JungMinuJungMinuJungMinu approved these changes

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.webcrypto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@panva@nodejs-github-bot@aduh95@lpinca@anonrig@tniessen@JungMinu