crypto: fix CryptoKey WebIDL conformance#45855
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Dec 14, 2022
Review requested:
|
aduh95 approved these changes Dec 14, 2022
panva added author ready 
github-actionsbot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
lpinca approved these changes Dec 14, 2022
This comment was marked as outdated.
This comment was marked as outdated.
panva added the commit-queue 
tniessen approved these changes Dec 14, 2022
This comment was marked as outdated.
This comment was marked as outdated.
9 tasks
Collaborator
nodejs-github-bot commented Dec 15, 2022
7 tasks
panva removed the commit-queue 
MemberAuthor
panva commented Dec 16, 2022
Landed in 43b7189 |
panva added a commit that referenced this pull request Dec 16, 2022
PR-URL: #45855 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Contributor
aduh95 commented Dec 16, 2022
This landed despite the latest Jenkins CI being red (and this change does affect the node/doc/contributing/collaborator-guide.md Lines 207 to 211 in 6831e2f |
This was referenced Dec 17, 2022
14 tasks
targos pushed a commit that referenced this pull request Jan 1, 2023
PR-URL: #45855 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
PR-URL: #45855 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CryptoKey getters need to check
thisand be enumerable.