crypto: fix remaining WebCryptoAPI idlharness WPTs#45857
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Dec 14, 2022
Review requested:
|
nodejs-github-bot added crypto 
panva added commit-queue-squash panvaforce-pushed the fix-cryptokey-prototype branch from 840aac6 to b5e59e3Comparepanva added request-ci 
panvaforce-pushed the fix-cryptokey-prototype branch from b5e59e3 to b9a06a0Compare
github-actionsbot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
panva added the commit-queue-rebase panva changed the title This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aduh95 reviewed Dec 17, 2022
Uh oh!
There was an error while loading. Please reload this page.
panvaforce-pushed the fix-cryptokey-prototype branch from d864774 to dc6e9a8Comparenodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Dec 20, 2022
Landed in 7738844...3f3966c |
nodejs-github-bot pushed a commit that referenced this pull request Dec 20, 2022
PR-URL: #45857 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Dec 20, 2022
PR-URL: #45857 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Dec 20, 2022
PR-URL: #45857 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Dec 21, 2022
targos pushed a commit that referenced this pull request Jan 1, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jan 1, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jan 1, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
juanarbol commented Jan 22, 2023
Depends on #45659 |
MemberAuthor
panva commented Jan 23, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
PR-URL: #45857 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
Cryptokeyto be just a non-constructable wrapper, not having any of the transferable related getters, moving those toInternalCryptoKey.JSTransferable remains in effect, but will rebase and run ci after #45811 lands to reconfirm (done).
Also fixes (adds)
globalThis.cryptothischeck.