fs: handle fixes#45909
Closed
fs: handle fixes #45909
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ronag added the good first issue 
nodejs-github-bot added fs 
ronag referenced this pull request Dec 19, 2022
Support creating a Read/WriteStream from a FileHandle instead of a raw file descriptor Add an EventEmitter to FileHandle with a single 'close' event. Fixes: #35240 PR-URL: #35922 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
ronag removed the good first issue 
MemberAuthor
@nodejs/fs @mcollina |
ronag commented Dec 25, 2022
| thrownewERR_METHOD_NOT_IMPLEMENTED('open()'); | ||
| }, | ||
| close: (fd,cb)=>{ | ||
| handle.off('close',closeHandler); |
MemberAuthor
There was a problem hiding this comment.
Avoid keeping stream alive until file handle is closed.
ronag commented Dec 25, 2022
| ()=>cb(),cb); | ||
| if(handle[kFd]!==-1){ | ||
| // Someone else has a ref to the handle. | ||
| process.nextTick(cb); |
MemberAuthor
There was a problem hiding this comment.
stream can finish teardown even if file handle isn't closed, if it has refs
ronag commented Dec 25, 2022
| ()=>{this[kClosePromise]=undefined;} | ||
| ()=>{ | ||
| this[kClosePromise]=undefined; | ||
| this.emit('close'); |
MemberAuthor
There was a problem hiding this comment.
Only emit close after actually closing.
Contributor
Slayer95 commented Mar 3, 2023
I'm afraid this PR flew under people's radar. |
aduh95 reviewed Mar 3, 2023
Contributor
aduh95 left a comment
aduh95 left a comment There was a problem hiding this comment.
LGTM except the test failures
aduh95 reviewed Mar 3, 2023
Contributor
aduh95 left a comment
aduh95 left a comment There was a problem hiding this comment.
LGTM except the test failures
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixes found while reviewing code. I don't plan on working further on this so if someone wants to finish up with the test be my guest.