Skip to content

src: use string_view for FastStringKey implementation#45914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 3 commits into from
Dec 21, 2022
Merged

src: use string_view for FastStringKey implementation #45914

nodejs-github-bot merged 3 commits into from
Dec 21, 2022

Conversation

@addaleax
Copy link
Member

@addaleaxaddaleax commented Dec 19, 2022

No description provided.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 19, 2022

Review requested:

  • @nodejs/startup

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 19, 2022
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 19, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48616/

@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 19, 2022
legendecas
legendecas reviewed Dec 20, 2022
View reviewed changes
legendecas
legendecas approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@legendecaslegendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48627/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48644/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48657/

@github-actionsgithub-actionsbot mentioned this pull request Dec 21, 2022
Open
12 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48668/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48676/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48677/

@addaleaxaddaleax added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 21, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2022
@nodejs-github-botnodejs-github-bot merged commit 1773b2a into nodejs:mainDec 21, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2022

Landed in 1773b2a

@addaleaxaddaleax deleted the faststringkey-stringview branch December 21, 2022 22:49
This was referenced Dec 22, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 29, 2022
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
@addaleax@targos
src: use string_view for FastStringKey implementation
192ca1a
PR-URL: #45914 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
@addaleax@RafaelGSS
src: use string_view for FastStringKey implementation
52eb054
PR-URL: #45914 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
@addaleax@RafaelGSS
src: use string_view for FastStringKey implementation
c2ed0cc
PR-URL: #45914 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@addaleax@juanarbol
src: use string_view for FastStringKey implementation
0344dce
PR-URL: #45914 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@juanarboljuanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@addaleax@juanarbol
src: use string_view for FastStringKey implementation
9ca31cd
PR-URL: #45914 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@anonriganonriganonrig approved these changes

@tniessentniessentniessen approved these changes

@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@nodejs-github-bot@jasnell@anonrig@tniessen@legendecas