Skip to content

Conversation

@deokjinkim
Copy link
Contributor

Tailing slash of url.href is ommited.

Tailing slash of url.href is ommited.
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Dec 21, 2022
@aduh95aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 21, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2022
@nodejs-github-botnodejs-github-bot merged commit f3dd3fe into nodejs:mainDec 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in f3dd3fe

targos pushed a commit that referenced this pull request Jan 1, 2023
Tailing slash of url.href is ommited. PR-URL: #45928 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2023
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
Tailing slash of url.href is ommited. PR-URL: #45928 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
Tailing slash of url.href is ommited. PR-URL: #45928 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
Tailing slash of url.href is ommited. PR-URL: #45928 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@juanarboljuanarbol mentioned this pull request Jan 28, 2023
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
Tailing slash of url.href is ommited. PR-URL: #45928 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.urlIssues and PRs related to the legacy built-in url module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@deokjinkim@nodejs-github-bot@cjihrig@aduh95