test: fix flakyness in test-runner reporter test

[MoLow]

Fixes: #45929

[MoLow]

CC @nodejs/test_runner

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48673/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48679/

[github-actions]

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/45930 ✔ Done loading data for nodejs/node/pull/45930 ----------------------------------- PR info ------------------------------------ Title test: fix flakyness in test-runner reporter test (#45930) Author Moshe Atlow (@MoLow) Branch MoLow:fix-reporter-test-fluke -> nodejs:main Labels test, flaky-test, fast-track, author ready, needs-ci Commits 3 - test: fix flakyness in test-runner reporter test - Update test/parallel/test-runner-reporters.js - lint Committers 2 - Moshe Atlow - GitHub PR-URL: https://github.com/nodejs/node/pull/45930 Fixes: https://github.com/nodejs/node/issues/45929 Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45930 Fixes: https://github.com/nodejs/node/issues/45929 Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 21 Dec 2022 07:52:51 GMT ✔ Approvals: 4 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45930#pullrequestreview-1226347233 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45930#pullrequestreview-1226358434 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45930#pullrequestreview-1226366242 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45930#pullrequestreview-1226450466 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-12-21T19:56:28Z: https://ci.nodejs.org/job/node-test-pull-request/48679/ - Querying data for job/node-test-pull-request/48679/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 45930 From https://github.com/nodejs/node * branch refs/pull/45930/merge -> FETCH_HEAD ✔ Fetched commits as 1773b2ada4b2..49c4df76839b -------------------------------------------------------------------------------- [main 05d974dcd0] test: fix flakyness in test-runner reporter test Author: Moshe Atlow Date: Wed Dec 21 09:52:11 2022 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main b8e0cf694c] Update test/parallel/test-runner-reporters.js Author: Moshe Atlow Date: Wed Dec 21 13:50:45 2022 +0200 1 file changed, 3 insertions(+), 1 deletion(-) [main a9e78837a0] lint Author: Moshe Atlow Date: Wed Dec 21 17:37:30 2022 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6) 
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 test: fix flakyness in test-runner reporter test
PR-URL: #45930
 Fixes: #45929
 Reviewed-By: Luigi Pinca [email protected]
 Reviewed-By: Yagiz Nizipli [email protected]
 Reviewed-By: Colin Ihrig [email protected]
 Reviewed-By: Antoine du Hamel [email protected]
[detached HEAD e2b4100fbf] test: fix flakyness in test-runner reporter test
 Author: Moshe Atlow [email protected]
 Date: Wed Dec 21 09:52:11 2022 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
 Rebasing (3/6)
 Rebasing (4/6)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 Update test/parallel/test-runner-reporters.js
Co-authored-by: Antoine du Hamel [email protected]
 PR-URL: #45930
 Fixes: #45929
 Reviewed-By: Luigi Pinca [email protected]
 Reviewed-By: Yagiz Nizipli [email protected]
 Reviewed-By: Colin Ihrig [email protected]
 Reviewed-By: Antoine du Hamel [email protected]
[detached HEAD cc4fed35c6] Update test/parallel/test-runner-reporters.js
 Author: Moshe Atlow [email protected]
 Date: Wed Dec 21 13:50:45 2022 +0200
 1 file changed, 3 insertions(+), 1 deletion(-)
 Rebasing (5/6)
 Rebasing (6/6)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 lint
PR-URL: #45930
 Fixes: #45929
 Reviewed-By: Luigi Pinca [email protected]
 Reviewed-By: Yagiz Nizipli [email protected]
 Reviewed-By: Colin Ihrig [email protected]
 Reviewed-By: Antoine du Hamel [email protected]
[detached HEAD ef9c4c2b8d] lint
 Author: Moshe Atlow [email protected]
 Date: Wed Dec 21 17:37:30 2022 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/3753956979

[nodejs-github-bot]

Landed in 71951a0

[RafaelGSS]

This commit didn't land cleanly on v19.x due to the need to drop #45712. I'll include the labels dont-land-on-vXX to avoid further conflicts. Feel free to remove them when the bug is resolved.

[danielleadams]

This broke tests on v18.x, so requesting a backport if this should go into 18.

[MoLow]

the test on v18.x-staging behaves the same as this fix, so no need to backport

[ruyadorno]

adding https://github.com/nodejs/node/labels/dont-land-on-v18.x label to avoid having this show up on v18.x staging again since it's not needed