[v18.x backport] test_runner: avoid swallowing of asynchronously thrown errors#46005
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Dec 29, 2022
Review requested:
|
nodejs-github-bot added dont-land-on-v14.x needs-ci 
MoLow approved these changes Dec 29, 2022
Collaborator
nodejs-github-bot commented Dec 30, 2022
This was referenced Dec 31, 2022
danielleadamsforce-pushed the v18.x-staging branch from 68cca1e to 2098d7aCompare
20 tasks
danielleadamsforce-pushed the v18.x-staging branch from 2098d7a to bac6b7dCompare22 tasks
Member
juanarbol commented Jan 22, 2023
Hey! Thanks for this patch. Would you mind rebasing this? |
According to https://html.spec.whatwg.org/#environment-settings-object, the timeOrigin is a per-environment value. Worker's timeOrigin is the time when the worker is created. PR-URL: nodejs#43781 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
To distinguish per-context values from the node::Environment, split those values to a new node::Realm structure and consolidate bootstrapping methods with it. PR-URL: nodejs#44179 Refs: nodejs#42528 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: nodejs#44612 PR-URL: nodejs#45264 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
fossamagnaforce-pushed the backport-v18-test-runner-extraneous-async-fail branch from 6bba8f9 to 024450aCompare
ContributorAuthor
fossamagna commented Jan 24, 2023
@juanarbol Thanks. I rebased and pushed this PR. |
MoLow added request-ci 
Member
MoLow commented Jan 26, 2023
the rebase did not seem to be successful, so I am closing in favor of #46360 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This RP is backport of #45264 to v18.x.
Refs: #45264 (comment)