module: fix unintended mutation#46108
Merged
+10 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jan 5, 2023
Review requested:
|
RafaelGSS approved these changes Jan 5, 2023
jasnell approved these changes Jan 5, 2023
aduh95 added author ready 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jan 5, 2023
arcanis approved these changes Jan 5, 2023
GeoffreyBooth approved these changes Jan 5, 2023
Member
GeoffreyBooth commented Jan 5, 2023
It’s not all that clear to me how to trigger the error that this is meant to fix; is there a minimal case you could include in the PR description so we have it for reference? Or maybe include as a unit test? |
lpinca approved these changes Jan 5, 2023
ContributorAuthor
CITGM: https://ci.nodejs.org/job/citgm-smoker/3075/ |
Collaborator
nodejs-github-bot commented Jan 6, 2023
Member
GeoffreyBooth commented Jan 6, 2023
Is this meant as an answer to my question? |
JakobJingleheimer approved these changes Jan 6, 2023
Collaborator
nodejs-github-bot commented Jan 6, 2023
ContributorAuthor
aduh95 commented Jan 6, 2023
It's not clear to me either, however it's fixing the CITGM for |
aduh95 added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jan 7, 2023
Landed in 693b6fb |
This was referenced Jan 11, 2023
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
Refs: nodejs#46061 (comment) PR-URL: nodejs#46108 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
Refs: #46061 (comment) PR-URL: #46108 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
Refs: #46061 (comment) PR-URL: #46108 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
Refs: #46061 (comment) PR-URL: #46108 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #46061 (comment)