Skip to content

Conversation

@mhdawson
Copy link
Member

  • add text discussed by the TSC

Signed-off-by: Michael Dawson [email protected]

- add text discussed by the TSC Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 6, 2023
@bnoordhuis
Copy link
Member

Did something prompt this? The blurb has a strong "water is wet, news at 11" vibe and the README is already interminably long...

Aside: I'd be in favor of moving out the collaborators/triagers/etc. lists.

Co-authored-by: Rich Trott <[email protected]>
mhdawsonand others added 4 commits January 9, 2023 12:30
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Rich Trott <[email protected]>
@mhdawson
Copy link
MemberAuthor

@Trott I've incorporate all of your suggested changes.

Copy link
Member

@ChALkeRChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(Would expect it below code of conduct, but that's not very signiciant.)

@mhdawson
Copy link
MemberAuthor

I think the open questions have been discussed/answered. I meant to tag the TSC at begining with @nodejs/tsc which I'm doing now so that we get more TSC review before it lands. @nodejs/tsc.

Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhdawson
Copy link
MemberAuthor

Ok going to go ahead and land.

@mhdawson
Copy link
MemberAuthor

Landed in c62a860

mhdawson added a commit that referenced this pull request Jan 17, 2023
- add text discussed by the TSC Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46121 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joe Sepi <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
- add text discussed by the TSC Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#46121 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joe Sepi <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
- add text discussed by the TSC Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46121 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joe Sepi <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jan 20, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
- add text discussed by the TSC Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46121 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joe Sepi <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
@juanarboljuanarbol mentioned this pull request Jan 28, 2023
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
- add text discussed by the TSC Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46121 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joe Sepi <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

16 participants

@mhdawson@bnoordhuis@mcollina@mscdex@joesepi@ChALkeR@GeoffreyBooth@Trott@ronag@gireeshpunathil@BethGriggs@legendecas@aduh95@RafaelGSS@RaisinTen@nodejs-github-bot