test: add test to once() in event lib#46126
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
panva reviewed Jan 7, 2023
Uh oh!
There was an error while loading. Please reload this page.
panva reviewed Jan 7, 2023
Member
panva left a comment
panva left a comment There was a problem hiding this comment.
Please update the first commit message. It should not end with punctuation.
Uh oh!
There was an error while loading. Please reload this page.
Member
Trott commented Jan 7, 2023
While you're at, make the first word imperative mood. Maybe this?: |
ContributorAuthor
jdiaz-dev commented Jan 7, 2023
This test verify if eventEmmiter param is right
Trottforce-pushed the jonathanDiaz/adding-test-to-event-lib branch from 7e5e9fc to 187b5a3Compare
panva changed the title 
anonrig approved these changes Jan 8, 2023
anonrig added author ready 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jan 8, 2023
Collaborator
nodejs-github-bot commented Jan 8, 2023
panva approved these changes Jan 8, 2023
panva added the commit-queue 
Member
panva commented Jan 8, 2023
@jdiaz-dev thank you for your first contribution. Barring any objections from other collaborators your PR will automatically land on the main branch after it's been open for 48 hours. |
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jan 9, 2023
Landed in 702303d |
This was referenced Jan 11, 2023
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
This test verify if eventEmmiter param is right PR-URL: nodejs#46126 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
This test verify if eventEmmiter param is right PR-URL: #46126 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
This test verify if eventEmmiter param is right PR-URL: #46126 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
This test verify if eventEmmiter param is right PR-URL: #46126 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test verify if eventEmmiter param is right in once method