Skip to content

tools: add automation for updating postject dependency#46157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 3 commits into from
Jan 14, 2023
Merged

tools: add automation for updating postject dependency #46157

nodejs-github-bot merged 3 commits into from
Jan 14, 2023

Conversation

@RaisinTen
Copy link
Member

@RaisinTenRaisinTen commented Jan 10, 2023

Signed-off-by: Darshan Sen [email protected]

cc @nodejs/single-executable

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 10, 2023

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jan 10, 2023
tony-go
tony-go reviewed Jan 10, 2023
View reviewed changes
aduh95
aduh95 reviewed Jan 10, 2023
View reviewed changes
aduh95
aduh95 reviewed Jan 10, 2023
View reviewed changes
@RaisinTenRaisinTen added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 11, 2023
@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 12, 2023
mhdawson
mhdawson approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Jan 13, 2023

@facutuesca if you have a change to review as well that would be good.

@mhdawsonmhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsbot mentioned this pull request Jan 14, 2023
Open
19 tasks
@RaisinTenRaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 14, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTenRaisinTen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 14, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 14, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/48980/

@RaisinTenRaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2023
@nodejs-github-botnodejs-github-bot merged commit d7d9811 into nodejs:mainJan 14, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 14, 2023

Landed in d7d9811

@RaisinTenRaisinTen deleted the setup-updating-system-for-postject branch January 14, 2023 08:33
This was referenced Jan 15, 2023
Open
Open
Open
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@RaisinTen@RafaelGSS
tools: add automation for updating postject dependency
eed4244
Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs#46157 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This was referenced Jan 18, 2023
Open
Open
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@RaisinTen@RafaelGSS
tools: add automation for updating postject dependency
1aa4534
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #46157 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@RaisinTen@juanarbol
tools: add automation for updating postject dependency
36f63d7
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #46157 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@juanarboljuanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@RaisinTen@juanarbol
tools: add automation for updating postject dependency
1b0cc79
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #46157 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@tony-gotony-go mentioned this pull request Feb 3, 2023
Merged
@RaisinTenRaisinTen added the single-executable Issues and PRs related to single-executable applications label May 5, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhdawsonmhdawsonmhdawson approved these changes

@aduh95aduh95aduh95 approved these changes

+2 more reviewers

@aymen94aymen94aymen94 approved these changes

@tony-gotony-gotony-go approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.metaIssues and PRs related to the general management of the project.single-executableIssues and PRs related to single-executable applicationstoolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RaisinTen@nodejs-github-bot@mhdawson@aymen94@aduh95@tony-go