Skip to content

build: add extra semi check#46194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gengjiawen wants to merge 2 commits into from
Closed

build: add extra semi check #46194

gengjiawen wants to merge 2 commits into from

Conversation

@gengjiawen
Copy link
Member

@gengjiawengengjiawen commented Jan 13, 2023•
edited
Loading

Make more friendly with electronjs.

context: #46171 (comment)

cc @richardlau

Should fail until #46171 is merged.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 13, 2023

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 13, 2023
@gengjiawen
Copy link
MemberAuthor

gengjiawen commented Jan 13, 2023

https://github.com/nodejs/node/actions/runs/3908559309/jobs/6678809081 show flags works.

rebased to make CI green (#46171 merged now)

@gengjiawengengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 13, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/48962/

@gengjiawen
Copy link
MemberAuthor

gengjiawen commented Jan 13, 2023

simdutf upstream: simdutf/simdutf#207

@gengjiawengengjiawen mentioned this pull request Jan 13, 2023
Merged
This was referenced Jan 14, 2023
Open
Open
Open
@gengjiawengengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 16, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/48996/

@gengjiawengengjiawen added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jan 16, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 16, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsbot mentioned this pull request Jan 17, 2023
Open
17 tasks
@gengjiawengengjiawen added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 17, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 17, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 17, 2023

Landed in 8986bf8...17aa195

nodejs-github-bot pushed a commit that referenced this pull request Jan 17, 2023
@gengjiawen@nodejs-github-bot
build: add extra semi check
3e7043a
PR-URL: #46194 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jan 17, 2023
@gengjiawen@nodejs-github-bot
deps: cherrypick simdutf patch
17aa195
PR-URL: #46194 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@gengjiawengengjiawen deleted the feat/semi branch January 17, 2023 01:27
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@gengjiawen@RafaelGSS
build: add extra semi check
6ae29dd
PR-URL: nodejs#46194 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@gengjiawen@RafaelGSS
deps: cherrypick simdutf patch
43c4146
PR-URL: nodejs#46194 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
This was referenced Jan 18, 2023
Open
Open
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@gengjiawen@RafaelGSS
build: add extra semi check
370f621
PR-URL: #46194 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@gengjiawen@RafaelGSS
deps: cherrypick simdutf patch
3f9fb37
PR-URL: #46194 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@gengjiawen@juanarbol
build: add extra semi check
6c8a26c
PR-URL: #46194 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@gengjiawen@juanarbol
deps: cherrypick simdutf patch
ca6adb1
PR-URL: #46194 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@juanarboljuanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@gengjiawen@juanarbol
build: add extra semi check
3bf2371
PR-URL: #46194 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@gengjiawen@juanarbol
deps: cherrypick simdutf patch
340d76a
PR-URL: #46194 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@tniessentniessentniessen approved these changes

@richardlaurichardlaurichardlau approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gengjiawen@nodejs-github-bot@jasnell@lpinca@cjihrig@tniessen@richardlau@RaisinTen