tls_legacy: do not read on OpenSSL's stack#4624
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Do not attempt to read data from the socket whilst on OpenSSL's stack, weird things may happen, and this is most likely going to result in some kind of error.
Contributor
trevnorris commented Jan 11, 2016
Awesome. LGTM. |
MemberAuthor
indutny commented Jan 11, 2016
Thank you! CI: https://ci.nodejs.org/job/node-test-pull-request/1192/ |
Member
jasnell commented Jan 11, 2016
LGTM |
MemberAuthor
indutny commented Jan 11, 2016
cc @nodejs/crypto just in case |
MemberAuthor
indutny commented Jan 11, 2016
Landed in 5a2445b, thank you everyone! |
indutny added a commit that referenced this pull request Jan 11, 2016
Do not attempt to read data from the socket whilst on OpenSSL's stack, weird things may happen, and this is most likely going to result in some kind of error. PR-URL: #4624 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Jan 12, 2016
@indutny should this be rolled into v5.4.1 or should we wait for @nodejs/crypto to take a look? |
MemberAuthor
indutny commented Jan 12, 2016
It should be safe to roll it into v5.4.1 |
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
Do not attempt to read data from the socket whilst on OpenSSL's stack, weird things may happen, and this is most likely going to result in some kind of error. PR-URL: #4624 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
Do not attempt to read data from the socket whilst on OpenSSL's stack, weird things may happen, and this is most likely going to result in some kind of error. PR-URL: #4624 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
Do not attempt to read data from the socket whilst on OpenSSL's stack, weird things may happen, and this is most likely going to result in some kind of error. PR-URL: #4624 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
Do not attempt to read data from the socket whilst on OpenSSL's stack, weird things may happen, and this is most likely going to result in some kind of error. PR-URL: nodejs#4624 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
Do not attempt to read data from the socket whilst on OpenSSL's stack, weird things may happen, and this is most likely going to result in some kind of error. PR-URL: nodejs#4624 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Do not attempt to read data from the socket whilst on OpenSSL's stack, weird things may happen, and this is most likely going to result in some kind of error. PR-URL: nodejs#4624 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not attempt to read data from the socket whilst on OpenSSL's stack,
weird things may happen, and this is most likely going to result in some
kind of error.
R=@trevnorris
Let's land this change anyway, so it will be easier to work on our AsyncWrap stuff.
Not really going to introduce a test here, because this thing will fail once #4509 or any similar PR will land.