Skip to content

deps: update simdutf to 3.1.0#46257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nodejs-github-bot wants to merge 2 commits into from
Closed

deps: update simdutf to 3.1.0 #46257

nodejs-github-bot wants to merge 2 commits into from

Conversation

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-botnodejs-github-bot commented Jan 18, 2023•
edited by anonrig
Loading

Removes the need for #46256
Fixes#46235

@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jan 18, 2023
@anonriganonrig self-assigned this Jan 18, 2023
@anonriganonrig requested a review from addaleaxJanuary 18, 2023 21:00
@anonriganonrigforce-pushed the actions/tools-update-simdutf branch from c8f5ff7 to c85f1dfCompareJanuary 18, 2023 21:03
@anonriganonrig added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jan 18, 2023
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2023
@addaleaxaddaleax mentioned this pull request Jan 18, 2023
Closed
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2023
@nodejs-github-bot
Copy link
CollaboratorAuthor

nodejs-github-bot commented Jan 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49060/

@anonriganonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 18, 2023
@github-actions
Copy link
Contributor

github-actionsbot commented Jan 18, 2023

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2023
Trott
Trott approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM.

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2023
@nodejs-github-bot
Copy link
CollaboratorAuthor

nodejs-github-bot commented Jan 18, 2023

Landed in d896f5b...95c064d

nodejs-github-bot added a commit that referenced this pull request Jan 18, 2023
@nodejs-github-bot
deps: update simdutf to 3.1.0
7b2f1a1
PR-URL: #46257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jan 18, 2023
@anonrig@nodejs-github-bot
src: fix endianness of simdutf
95c064d
PR-URL: #46257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@addaleaxaddaleax deleted the actions/tools-update-simdutf branch January 19, 2023 12:45
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@nodejs-github-bot@RafaelGSS
deps: update simdutf to 3.1.0
26cde8e
PR-URL: #46257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@anonrig@RafaelGSS
src: fix endianness of simdutf
e482d5e
PR-URL: #46257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@nodejs-github-bot@juanarbol
deps: update simdutf to 3.1.0
594d638
PR-URL: #46257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@anonrig@juanarbol
src: fix endianness of simdutf
3536efe
PR-URL: #46257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@juanarboljuanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@nodejs-github-bot@juanarbol
deps: update simdutf to 3.1.0
b7fe8c7
PR-URL: #46257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]>
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@anonrig@juanarbol
src: fix endianness of simdutf
646cadc
PR-URL: #46257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QardQardQard approved these changes

@TrottTrottTrott approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@anonriganonriganonrig approved these changes

@joyeecheungjoyeecheungjoyeecheung approved these changes

Assignees

@anonriganonrig

Labels

commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.dependenciesPull requests that update a dependency file.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

segfault with shared builtin

7 participants

@nodejs-github-bot@Qard@Trott@addaleax@anonrig@joyeecheung