Skip to content

[v19.x backport] http: res set headers#46272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marco-ippolito wants to merge 2 commits into from
Closed

[v19.x backport] http: res set headers #46272

marco-ippolito wants to merge 2 commits into from

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolitomarco-ippolito commented Jan 19, 2023

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 19, 2023

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. v19.x labels Jan 19, 2023
@RafaelGSSRafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 20, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49096/

This was referenced Jan 21, 2023
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 24, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49150/

mcollina
mcollina approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actionsgithub-actionsbot mentioned this pull request Jan 25, 2023
Open
12 tasks
@marco-ippolitomarco-ippolito mentioned this pull request Jan 25, 2023
Merged
@ruyadorno
Copy link
Member

ruyadorno commented Jan 31, 2023

This looks like a semver-minor change to me. Does that make sense @marco-ippolito@RafaelGSS ?

@ruyadornoruyadorno added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 31, 2023
ruyadorno pushed a commit that referenced this pull request Jan 31, 2023
@marco-ippolito@ruyadorno
http: res.setHeaders first implementation
1ec6270
Backport-PR-URL: #46272 PR-URL: #46109 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
@ruyadorno
Copy link
Member

ruyadorno commented Jan 31, 2023

Landed in 1ec6270

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@RafaelGSSRafaelGSSRafaelGSS approved these changes

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.needs-ciPRs that need a full CI run.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marco-ippolito@nodejs-github-bot@ruyadorno@mcollina@RafaelGSS