Skip to content

stream: remove brandchecks from stream duplexify#46315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jan 25, 2023
Merged

stream: remove brandchecks from stream duplexify #46315

nodejs-github-bot merged 1 commit into from
Jan 25, 2023

Conversation

@debadree25
Copy link
Member

@debadree25debadree25 commented Jan 23, 2023

Using imports from webstreams could cause dependency issues in readable-stream as referenced in the discussion, hence removing brandchecks and replacing with utils in streams

Refs: #46190
Refs: #46205 (comment)

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 23, 2023

Review requested:

  • @nodejs/streams

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 23, 2023
@debadree25
Copy link
MemberAuthor

debadree25 commented Jan 23, 2023

cc @ronag

@ronag
Copy link
Member

ronag commented Jan 23, 2023

Thanks!

@debadree25
Copy link
MemberAuthor

debadree25 commented Jan 23, 2023

I think for backporting #46190 we could do it after this one lands? cc @aduh95

@debadree25debadree25 mentioned this pull request Jan 23, 2023
Closed
mcollina
mcollina approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 23, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49139/

@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2023
@addaleaxaddaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 24, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2023
@nodejs-github-botnodejs-github-bot merged commit ea5a123 into nodejs:mainJan 25, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 25, 2023

Landed in ea5a123

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@debadree25@ruyadorno
stream: remove brandchecks from stream duplexify
2e5e7a9
Refs: #46190 Refs: #46205 (comment) PR-URL: #46315 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@ruyadornoruyadorno mentioned this pull request Feb 1, 2023
Merged
debadree25 added a commit to debadree25/node that referenced this pull request Feb 27, 2023
@debadree25
stream: remove brandchecks from stream duplexify
832e4b0
Refs: nodejs#46190 Refs: nodejs#46205 (comment) PR-URL: nodejs#46315 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
debadree25 added a commit to debadree25/node that referenced this pull request Feb 27, 2023
@debadree25
stream: remove brandchecks from stream duplexify
53e9a77
Refs: nodejs#46190 Refs: nodejs#46205 (comment) PR-URL: nodejs#46315 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
debadree25 added a commit to debadree25/node that referenced this pull request Feb 27, 2023
@debadree25
stream: remove brandchecks from stream duplexify
a980376
Refs: nodejs#46190 Refs: nodejs#46205 (comment) PR-URL: nodejs#46315 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@debadree25@juanarbol
stream: remove brandchecks from stream duplexify
98d2a6e
Refs: #46190 Refs: #46205 (comment) PR-URL: #46315 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@juanarboljuanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@debadree25@juanarbol
stream: remove brandchecks from stream duplexify
5290766
Refs: #46190 Refs: #46205 (comment) PR-URL: #46315 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@debadree25@juanarbol
stream: remove brandchecks from stream duplexify
63e92ea
Refs: #46190 Refs: #46205 (comment) PR-URL: #46315 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
debadree25 added a commit to debadree25/node that referenced this pull request May 23, 2023
@debadree25
stream: remove brandchecks from stream duplexify
0291981
Refs: nodejs#46190 Refs: nodejs#46205 (comment) PR-URL: nodejs#46315 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
danielleadams pushed a commit that referenced this pull request May 29, 2023
@debadree25@danielleadams
stream: remove brandchecks from stream duplexify
e8b5a61
Refs: #46190 Refs: #46205 (comment) PR-URL: #46315 Backport-PR-URL: #46314 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
aduh95 pushed a commit to aduh95/node that referenced this pull request Feb 18, 2025
@debadree25@RafaelGSS
stream: remove brandchecks from stream duplexify
cfb18d8
Refs: nodejs#46190 Refs: nodejs#46205 (comment) PR-URL: nodejs#46315 Backport-PR-URL: nodejs#46314 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@benjamingrbenjamingrbenjamingr approved these changes

@lpincalpincalpinca approved these changes

@ronagronagronag approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@debadree25@nodejs-github-bot@ronag@mcollina@addaleax@benjamingr@lpinca@RaisinTen