test: make more crypto tests work with BoringSSL#46429
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
codebytere changed the title 
nodejs-github-bot added needs-ci 
codebytere changed the title codebytereforce-pushed the tests-for-boringssl branch from b7574c9 to 27c98b7Compare
lpinca approved these changes Jan 30, 2023
github-actionsbot removed the request-ci 
This comment was marked as outdated.
This comment was marked as outdated.
panva approved these changes Jan 30, 2023
panva added the author ready 
jasnell approved these changes Jan 31, 2023
Member
tony-go commented Jan 31, 2023
tony-go approved these changes Jan 31, 2023
Collaborator
nodejs-github-bot commented Jan 31, 2023
Collaborator
nodejs-github-bot commented Jan 31, 2023
codebytere added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 1, 2023
Landed in 8e42d8c |
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
PR-URL: #46429 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46429 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tweaks several crypto tests to work with BoringSSL so that Electron does not need to disable them and can smoke test our embedded Node.js executable with them.