wasi: add wasi sock_accept stub#46434
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jan 31, 2023
Review requested:
|
nodejs-github-bot added c++ 
mhdawson removed the wasi mhdawson added the wasi 
jasnell approved these changes Jan 31, 2023
cjihrig approved these changes Jan 31, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mhdawson commented Jan 31, 2023
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
mhdawson commented Jan 31, 2023
Pushed commit to address all comment so far. |
MemberAuthor
mhdawson commented Jan 31, 2023
As mentioned needs an updated version of uvwasi before tests will pass. |
Signed-off-by: Michael Dawson <[email protected]>
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <[email protected]>
MemberAuthor
mhdawson commented Feb 23, 2023
Just added commit to update uvwasi to v0.0.16 so that tests can pass. @cjihrig a re-LGTM from you might make sense due to that addition. |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Feb 23, 2023
cjihrig approved these changes Feb 23, 2023
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
The release commit LGTM. Assuming the other commit hasn't changed, the PR LGTM
mhdawson added a commit that referenced this pull request Mar 1, 2023
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
mhdawson added a commit that referenced this pull request Mar 1, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
mhdawson commented Mar 1, 2023
Landed in 8e4fa26...bd04106 |
targos pushed a commit that referenced this pull request Mar 13, 2023
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Mar 13, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Contributor
danielleadams commented Apr 3, 2023
@mhdawson this didn't land cleanly on v18.x-staging. Do you mind opening a backport PR to v18.x? Thank you |
MemberAuthor
mhdawson commented Apr 4, 2023
@danielleadams thanks for the head up. Will add it to my list of things. |
mhdawson added a commit to mhdawson/io.js that referenced this pull request Apr 6, 2023
Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#46434 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
mhdawson added a commit to mhdawson/io.js that referenced this pull request Apr 6, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#46434 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
mhdawson commented Apr 6, 2023
@danielleadams PR for backport - #47455 |
danielleadams pushed a commit that referenced this pull request May 29, 2023
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Backport-PR-URL: #47455 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
danielleadams pushed a commit that referenced this pull request May 29, 2023
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46434 Backport-PR-URL: #47455 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Feb 18, 2025
Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#46434 Backport-PR-URL: nodejs#47455 Refs: nodejs/uvwasi#185 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Feb 18, 2025
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#46434 Backport-PR-URL: nodejs#47455 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/uvwasi#185
Add stub for sock_accept so that we have stubs
for all of the sock methods in wasi_snapshot_preview1.
Its a bit awkward as the method was added after the
initial definitial of wasi_snapshot-preview1 but I
think it should be semver minor at most to add
the method.
Depends on nodejs/uvwasi#185
being landed in uvwasi first and an updated version
of uvwasi that includes that being pulled into
Node.js
Signed-off-by: Michael Dawson [email protected]