Skip to content

test_runner: fix missing test diagnostics#46450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Feb 2, 2023
Merged

test_runner: fix missing test diagnostics #46450

nodejs-github-bot merged 1 commit into from
Feb 2, 2023

Conversation

@MoLow
Copy link
Member

@MoLowMoLow commented Jan 31, 2023

Fixes: #45911

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 31, 2023

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jan 31, 2023
@MoLow
Copy link
MemberAuthor

MoLow commented Jan 31, 2023

CC @nodejs/test_runner @manekinekko

cjihrig
cjihrig approved these changes Jan 31, 2023
View reviewed changes
@MoLowMoLowforce-pushed the emit-test-diagnotsics branch from 391a2e1 to 0d76e4dCompareJanuary 31, 2023 20:06
@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 31, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49287/

manekinekko
manekinekko reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@manekinekkomanekinekko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 1, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49290/

@MoLowMoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2023
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2023
@MoLowMoLowforce-pushed the emit-test-diagnotsics branch from 0d76e4d to f9b919dCompareFebruary 2, 2023 10:50
@MoLow
Copy link
MemberAuthor

MoLow commented Feb 2, 2023

I've had to rebase after #46441 has landed
can someone re-approve for the sake of commit-queueAdd this label to land a pull request using GitHub Actions. working?
CC @nodejs/test_runner

1 similar comment
@MoLow

This comment was marked as outdated.

Sign in to view
@MoLowMoLow added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 2, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49306/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2023
@nodejs-github-botnodejs-github-bot merged commit 1118db7 into nodejs:mainFeb 2, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2023

Landed in 1118db7

@MoLowMoLow deleted the emit-test-diagnotsics branch February 4, 2023 18:10
@github-actionsgithub-actionsbot mentioned this pull request Feb 5, 2023
Open
22 tasks
MoLow added a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
@MoLow
test_runner: fix missing test diagnostics
17f0e2d
PR-URL: nodejs/node#46450Fixes: nodejs/node#45911 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> (cherry picked from commit 1118db718c8429f5f343aca90ccb570244e282b4)
MoLow added a commit to MoLow/node-core-test that referenced this pull request Feb 7, 2023
@MoLow
fix: fix missing test diagnostics
22ccbdf
PR-URL: nodejs/node#46450Fixes: nodejs/node#45911 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> (cherry picked from commit 1118db718c8429f5f343aca90ccb570244e282b4)
MoLow added a commit to nodejs/node-core-test that referenced this pull request Feb 8, 2023
@MoLow
fix: fix missing test diagnostics
b5b3f0b
PR-URL: nodejs/node#46450Fixes: nodejs/node#45911 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> (cherry picked from commit 1118db718c8429f5f343aca90ccb570244e282b4)
MoLow added a commit to MoLow/node that referenced this pull request Feb 18, 2023
@MoLow
test_runner: fix missing test diagnostics
e759516
PR-URL: nodejs#46450Fixes: nodejs#45911 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@MoLow@MylesBorins
test_runner: fix missing test diagnostics
c526f9f
PR-URL: #46450Fixes: #45911 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 19, 2023
Merged
MoLow added a commit to MoLow/node that referenced this pull request Feb 25, 2023
@MoLow
test_runner: fix missing test diagnostics
194ef53
PR-URL: nodejs#46450Fixes: nodejs#45911 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Feb 25, 2023
@MoLow
test_runner: fix missing test diagnostics
e8fdd04
PR-URL: nodejs#46450Fixes: nodejs#45911 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Feb 25, 2023
@MoLow
test_runner: fix missing test diagnostics
f4264f0
PR-URL: nodejs#46450Fixes: nodejs#45911 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@MoLow@juanarbol
test_runner: fix missing test diagnostics
b48ad99
PR-URL: #46450 Backport-PR-URL: #46839Fixes: #45911 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
@juanarboljuanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@MoLow@juanarbol
test_runner: fix missing test diagnostics
ba784e8
PR-URL: #46450 Backport-PR-URL: #46839Fixes: #45911 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes

@aduh95aduh95aduh95 approved these changes

@benjamingrbenjamingrAwaiting requested review from benjamingr

+2 more reviewers

@manekinekkomanekinekkomanekinekko left review comments

@tony-gotony-gotony-go approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test diagnostics are ommited when running with --test

6 participants

@MoLow@nodejs-github-bot@manekinekko@cjihrig@aduh95@tony-go