stream: fix respondWithNewView() errors when view.byteOffset != 0#46465
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell approved these changes Feb 3, 2023
JungMinu approved these changes Feb 6, 2023
debadree25 added request-ci 
github-actionsbot removed the request-ci 
This comment was marked as outdated.
This comment was marked as outdated.
MemberAuthor
debadree25 commented Feb 18, 2023
@nodejs/whatwg-stream |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Feb 24, 2023
debadree25 added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 24, 2023
Landed in 1f75a95 |
targos pushed a commit that referenced this pull request Mar 13, 2023
Fixes: #42851 Refs: https://github.com/whatwg/streams/blob/f894acdd417926a2121710803cef593e15127964/reference-implementation/lib/abstract-ops/readable-streams.js#L1756 PR-URL: #46465 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
Fixes: #42851 Refs: https://github.com/whatwg/streams/blob/f894acdd417926a2121710803cef593e15127964/reference-implementation/lib/abstract-ops/readable-streams.js#L1756 PR-URL: #46465 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #42851
Refs: https://github.com/whatwg/streams/blob/f894acdd417926a2121710803cef593e15127964/reference-implementation/lib/abstract-ops/readable-streams.js#L1756