src: avoid leaking snapshot fp on error#46497
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Call fclose() on the snapshot file regardless of whether reading the snapshot data succeeded.
Collaborator
nodejs-github-bot commented Feb 4, 2023
Review requested:
|
nodejs-github-bot added c++ 
addaleax approved these changes Feb 4, 2023
joyeecheung approved these changes Feb 4, 2023
lpinca approved these changes Feb 4, 2023
github-actionsbot removed the request-ci This comment was marked as outdated.
This comment was marked as outdated.
jasnell approved these changes Feb 4, 2023
22 tasks
This comment was marked as outdated.
This comment was marked as outdated.
tniessen added the author ready Collaborator
nodejs-github-bot commented Feb 5, 2023
19 tasks
RaisinTen approved these changes Feb 6, 2023
Collaborator
nodejs-github-bot commented Feb 6, 2023
tniessen added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 6, 2023
Landed in 3344bb7 |
18 tasks
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
Call fclose() on the snapshot file regardless of whether reading the snapshot data succeeded. PR-URL: #46497 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
Call fclose() on the snapshot file regardless of whether reading the snapshot data succeeded. PR-URL: #46497 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
fclose()on the snapshot file regardless of whether reading the snapshot data succeeded.