Skip to content

[v18.x] deps: V8: cherry-pick c875e86df1d7#46501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sepehrst wants to merge 1 commit into from
Closed

[v18.x] deps: V8: cherry-pick c875e86df1d7 #46501

sepehrst wants to merge 1 commit into from

Conversation

@sepehrst
Copy link

@sepehrstsepehrst commented Feb 5, 2023

Original commit message:

[bigint] Convert BigInt property names to decimal Hexadecimal/octal/binary BigInt property names should be converted to decimal, i.e. the following object literals should all be equivalent: var o ={0xF: 1}, p ={0xFn: 1}, q ={15: 1}, r ={15n: 1}. Test case by [email protected], uploaded at https://chromium-review.googlesource.com/c/v8/v8/+/3634937 Fixed: v8:10600 Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/main@{#80490}

Refs: v8/v8@c875e86
Refs: #43203 (comment)

@sepehrst
deps: V8: cherry-pick c875e86df1d7 (#2)
85c7432
Original commit message: [bigint] Convert BigInt property names to decimal Hexadecimal/octal/binary BigInt property names should be converted to decimal, i.e. the following object literals should all be equivalent: var o ={0xF: 1}, p ={0xFn: 1}, q ={15: 1}, r ={15n: 1}. Test case by [email protected], uploaded at https://chromium-review.googlesource.com/c/v8/v8/+/3634937 Fixed: v8:10600 Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/main@{#80490} Refs: v8/v8@c875e86
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 5, 2023

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Feb 5, 2023
@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 5, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49392/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 5, 2023

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5161/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 5, 2023

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5161/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 5, 2023

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5161/

@github-actionsgithub-actionsbot mentioned this pull request Feb 6, 2023
Open
19 tasks
@github-actionsgithub-actionsbot mentioned this pull request Feb 7, 2023
Open
18 tasks
@MylesBorinsMylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49714/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 18, 2023

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5183/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 18, 2023

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5183/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 18, 2023

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5183/

This was referenced Feb 20, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 23, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49959/

@github-actionsgithub-actionsbot mentioned this pull request Feb 25, 2023
Open
28 tasks
@sepehrst

This comment was marked as resolved.

Sign in to view
This was referenced Feb 26, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 27, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50045/

juanarbol pushed a commit to juanarbol/node that referenced this pull request Mar 1, 2023
@sepehrst@juanarbol
deps: V8: cherry-pick c875e86df1d7 (nodejs#2)
795f9d8
Original commit message: [bigint] Convert BigInt property names to decimal Hexadecimal/octal/binary BigInt property names should be converted to decimal, i.e. the following object literals should all be equivalent: var o ={0xF: 1}, p ={0xFn: 1}, q ={15: 1}, r ={15n: 1}. Test case by [email protected], uploaded at https://chromium-review.googlesource.com/c/v8/v8/+/3634937 Fixed: v8:10600 Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/main@{#80490} Refs: v8/v8@c875e86 PR-URL: nodejs#46501 Refs: v8/v8@c875e86 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
@juanarbol
Copy link
Member

juanarbol commented Mar 1, 2023

Landed in 795f9d8

@juanarboljuanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@sepehrst@juanarbol
deps: V8: cherry-pick c875e86df1d7
3ea53c5
Original commit message: [bigint] Convert BigInt property names to decimal Hexadecimal/octal/binary BigInt property names should be converted to decimal, i.e. the following object literals should all be equivalent: var o ={0xF: 1}, p ={0xFn: 1}, q ={15: 1}, r ={15n: 1}. Test case by [email protected], uploaded at https://chromium-review.googlesource.com/c/v8/v8/+/3634937 Fixed: v8:10600 Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/main@{#80490} Refs: v8/v8@c875e86 PR-URL: #46501 Refs: v8/v8@c875e86 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
@sepehrstsepehrst deleted the cherrypick-v8-c875e86df1d7-v18 branch March 17, 2023 05:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes

@gengjiawengengjiawengengjiawen approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.v8 engineIssues and PRs related to the V8 dependency.v18.xIssues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sepehrst@nodejs-github-bot@juanarbol@targos@gengjiawen@MylesBorins