crypto: don't assume FIPS is disabled by default#46532
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
For binaries that use --shared-openssl FIPs may be enabled by default by the system. Allow --force-fips and --enable-fips to be specified in these cases. Signed-off-by: Michael Dawson <[email protected]>
Collaborator
nodejs-github-bot commented Feb 6, 2023
Review requested:
|
nodejs-github-bot added c++ 
MemberAuthor
mhdawson commented Feb 6, 2023
One of our teams ran into this when using FIPS with Red Hat Enterprise Linux with FIPs enabled in the system. |
Signed-off-by: Michael Dawson <[email protected]>
richardlau approved these changes Feb 6, 2023
richardlau added the commit-queue-squash 
jasnell approved these changes Feb 7, 2023
cjihrig approved these changes Feb 7, 2023
tniessen approved these changes Feb 7, 2023
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Feb 7, 2023
Collaborator
nodejs-github-bot commented Feb 7, 2023
mhdawson added a commit that referenced this pull request Feb 17, 2023
For binaries that use --shared-openssl FIPs may be enabled by default by the system. Allow --force-fips and --enable-fips to be specified in these cases. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46532 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MemberAuthor
mhdawson commented Feb 17, 2023
Landed in 18651ad |
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
For binaries that use --shared-openssl FIPs may be enabled by default by the system. Allow --force-fips and --enable-fips to be specified in these cases. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46532 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Feb 20, 2023
For binaries that use --shared-openssl FIPs may be enabled by default by the system. Allow --force-fips and --enable-fips to be specified in these cases. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46532 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
For binaries that use --shared-openssl FIPs may be enabled by default by the system. Allow --force-fips and --enable-fips to be specified in these cases. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46532 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For binaries that use --shared-openssl FIPs may be enabled by default by the system. Allow --force-fips and --enable-fips to be specified in these cases.
Signed-off-by: Michael Dawson [email protected]