docs: update gpg key for Myles Borins#4657
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original key did not have personal information associated with it. The new key rectifies this problem
ContributorAuthor
MylesBorins commented Jan 13, 2016
Contributor
cjihrig commented Jan 13, 2016
LGTM |
Member
rvagg commented Jan 13, 2016
I believe these errors are just debug messages https://bugs.gnupg.org/gnupg/issue1934, I can't test this on my Linux machine atm so this is just OSX. Does anyone else get odd messages when importing the new key? |
Contributor
cjihrig commented Jan 13, 2016
@rvagg I saw similar error messages importing @thealphanerd and @evanlucas keys when they joined the release team. EDIT: Also: |
Member
rvagg commented Jan 13, 2016
ok .. well it imported, so lgtm I suppose |
This was referenced Jan 13, 2016
Merged
Member
jasnell commented Jan 13, 2016
LGTM |
jasnell pushed a commit that referenced this pull request Jan 13, 2016
Original key did not have personal information associated with it. The new key rectifies this problem PR-URL: #4657 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Jan 13, 2016
Landed in 287325c |
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
Original key did not have personal information associated with it. The new key rectifies this problem PR-URL: #4657 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: James M Snell <[email protected]>
Starefossen pushed a commit to Starefossen/docker-node that referenced this pull request Jan 13, 2016
PR-URL: nodejs#85 Related: nodejs/node#4657 Signed-off-by: Hans Kristian Flaatten <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
Original key did not have personal information associated with it. The new key rectifies this problem PR-URL: #4657 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Jan 14, 2016
Original key did not have personal information associated with it. The new key rectifies this problem PR-URL: #4657 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
Original key did not have personal information associated with it. The new key rectifies this problem PR-URL: #4657 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
bnoordhuis commented Jan 14, 2016
Should there perhaps be some kind of audit trail in the docs to help users understand why Myles' key changed between releases? It's going to be confusing now when they download an older binary or tarball. |
ContributorAuthor
MylesBorins commented Jan 14, 2016
@bnoordhuis v5.4.1 was signed by @Fishrock123 to avoid that exact case. My prior key was never used |
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Original key did not have personal information associated with it. The new key rectifies this problem PR-URL: #4657 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Original key did not have personal information associated with it. The new key rectifies this problem PR-URL: nodejs#4657 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original key did not have personal information associated with it.
The new key rectifies this problem