http: add note about clientError event#46584
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ShogunPanda added doc 
Collaborator
nodejs-github-bot commented Feb 9, 2023
Review requested:
|
Contributor
Fast-track has been requested by @ShogunPanda. Please 👍 to approve. |
lpinca approved these changes Feb 9, 2023
aduh95 approved these changes Feb 12, 2023
aduh95 added author ready 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 12, 2023
Landed in 331697c |
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
PR-URL: #46584 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Feb 20, 2023
PR-URL: #46584 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46584 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the document that during clientError the socket MUST be closed.
Fixes#43548.