Skip to content

doc: add response.strictContentLength to documentation#46627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 3 commits into from
Feb 14, 2023
Merged

doc: add response.strictContentLength to documentation #46627

nodejs-github-bot merged 3 commits into from
Feb 14, 2023

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolitomarco-ippolito commented Feb 12, 2023•
edited by aduh95
Loading

While working on this issue #46602, I've noticed the documentation for response.strictContentLength was missing.
it was added in this pr: #44378

Refs: #44378

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 12, 2023

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Feb 12, 2023
aduh95
aduh95 reviewed Feb 12, 2023
View reviewed changes
@marco-ippolito@aduh95
doc: fix added in version
d1013a1
Co-authored-by: Antoine du Hamel <[email protected]>
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 13, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 14, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 14, 2023

Commit Queue failed
- Loading data for nodejs/node/pull/46627 ✔ Done loading data for nodejs/node/pull/46627 ----------------------------------- PR info ------------------------------------ Title doc: add response.strictContentLength to documentation (#46627) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:fix/strict-content-length -> nodejs:main Labels http, doc, author ready Commits 3 - doc: add response.strictContentLength to documentation - doc: fix link - doc: fix added in version Committers 2 - Marco Ippolito - GitHub PR-URL: https://github.com/nodejs/node/pull/46627 Refs: https://github.com/nodejs/node/pull/44378 Reviewed-By: Robert Nagy Reviewed-By: Antoine du Hamel Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Harshitha K P ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46627 Refs: https://github.com/nodejs/node/pull/44378 Reviewed-By: Robert Nagy Reviewed-By: Antoine du Hamel Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Harshitha K P -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 12 Feb 2023 15:20:55 GMT ✔ Approvals: 5 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/46627#pullrequestreview-1295078964 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46627#pullrequestreview-1295173279 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/46627#pullrequestreview-1295207254 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46627#pullrequestreview-1296415306 ✔ - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/46627#pullrequestreview-1297066156 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 46627 From https://github.com/nodejs/node * branch refs/pull/46627/merge -> FETCH_HEAD ✔ Fetched commits as f46515c2f319..d1013a16acf4 -------------------------------------------------------------------------------- Auto-merging doc/api/http.md [main a6bb6170f3] doc: add response.strictContentLength to documentation Author: Marco Ippolito Date: Sun Feb 12 16:18:15 2023 +0100 1 file changed, 17 insertions(+), 2 deletions(-) Auto-merging doc/api/http.md [main aec53aaf94] doc: fix link Author: Marco Ippolito Date: Sun Feb 12 16:25:32 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) Auto-merging doc/api/http.md [main 163ec4c432] doc: fix added in version Author: Marco Ippolito Date: Sun Feb 12 17:52:44 2023 +0100 1 file changed, 3 insertions(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6) 
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 doc: add response.strictContentLength to documentation
PR-URL: #46627
 Refs: #44378
 Reviewed-By: Robert Nagy [email protected]
 Reviewed-By: Antoine du Hamel [email protected]
 Reviewed-By: Paolo Insogna [email protected]
 Reviewed-By: Luigi Pinca [email protected]
 Reviewed-By: Harshitha K P [email protected]
[detached HEAD f054e6fe99] doc: add response.strictContentLength to documentation
 Author: Marco Ippolito [email protected]
 Date: Sun Feb 12 16:18:15 2023 +0100
 1 file changed, 17 insertions(+), 2 deletions(-)
 Rebasing (3/6)
 Rebasing (4/6)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 doc: fix link
PR-URL: #46627
 Refs: #44378
 Reviewed-By: Robert Nagy [email protected]
 Reviewed-By: Antoine du Hamel [email protected]
 Reviewed-By: Paolo Insogna [email protected]
 Reviewed-By: Luigi Pinca [email protected]
 Reviewed-By: Harshitha K P [email protected]
[detached HEAD d2785e6282] doc: fix link
 Author: Marco Ippolito [email protected]
 Date: Sun Feb 12 16:25:32 2023 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
 Rebasing (5/6)
 Rebasing (6/6)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 doc: fix added in version
Co-authored-by: Antoine du Hamel [email protected]
 PR-URL: #46627
 Refs: #44378
 Reviewed-By: Robert Nagy [email protected]
 Reviewed-By: Antoine du Hamel [email protected]
 Reviewed-By: Paolo Insogna [email protected]
 Reviewed-By: Luigi Pinca [email protected]
 Reviewed-By: Harshitha K P [email protected]
[detached HEAD 289a0fc205] doc: fix added in version
 Author: Marco Ippolito [email protected]
 Date: Sun Feb 12 17:52:44 2023 +0100
 1 file changed, 3 insertions(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/4175330841

@ShogunPandaShogunPanda added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 14, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 14, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 14, 2023

Commit Queue failed
- Loading data for nodejs/node/pull/46627 ✔ Done loading data for nodejs/node/pull/46627 ----------------------------------- PR info ------------------------------------ Title doc: add response.strictContentLength to documentation (#46627) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:fix/strict-content-length -> nodejs:main Labels http, doc, author ready Commits 3 - doc: add response.strictContentLength to documentation - doc: fix link - doc: fix added in version Committers 2 - Marco Ippolito - GitHub PR-URL: https://github.com/nodejs/node/pull/46627 Refs: https://github.com/nodejs/node/pull/44378 Reviewed-By: Robert Nagy Reviewed-By: Antoine du Hamel Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Harshitha K P ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46627 Refs: https://github.com/nodejs/node/pull/44378 Reviewed-By: Robert Nagy Reviewed-By: Antoine du Hamel Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Harshitha K P -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 12 Feb 2023 15:20:55 GMT ✔ Approvals: 5 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/46627#pullrequestreview-1295078964 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46627#pullrequestreview-1295173279 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/46627#pullrequestreview-1295207254 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46627#pullrequestreview-1296415306 ✔ - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/46627#pullrequestreview-1297066156 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 46627 From https://github.com/nodejs/node * branch refs/pull/46627/merge -> FETCH_HEAD ✔ Fetched commits as fe514bf960ca..d1013a16acf4 -------------------------------------------------------------------------------- Auto-merging doc/api/http.md [main 6c51105641] doc: add response.strictContentLength to documentation Author: Marco Ippolito Date: Sun Feb 12 16:18:15 2023 +0100 1 file changed, 17 insertions(+), 2 deletions(-) Auto-merging doc/api/http.md [main ae1ac7f672] doc: fix link Author: Marco Ippolito Date: Sun Feb 12 16:25:32 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) Auto-merging doc/api/http.md [main 54dad3214f] doc: fix added in version Author: Marco Ippolito Date: Sun Feb 12 17:52:44 2023 +0100 1 file changed, 3 insertions(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6) 
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 doc: add response.strictContentLength to documentation
PR-URL: #46627
 Refs: #44378
 Reviewed-By: Robert Nagy [email protected]
 Reviewed-By: Antoine du Hamel [email protected]
 Reviewed-By: Paolo Insogna [email protected]
 Reviewed-By: Luigi Pinca [email protected]
 Reviewed-By: Harshitha K P [email protected]
[detached HEAD 356e29f18e] doc: add response.strictContentLength to documentation
 Author: Marco Ippolito [email protected]
 Date: Sun Feb 12 16:18:15 2023 +0100
 1 file changed, 17 insertions(+), 2 deletions(-)
 Rebasing (3/6)
 Rebasing (4/6)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 doc: fix link
PR-URL: #46627
 Refs: #44378
 Reviewed-By: Robert Nagy [email protected]
 Reviewed-By: Antoine du Hamel [email protected]
 Reviewed-By: Paolo Insogna [email protected]
 Reviewed-By: Luigi Pinca [email protected]
 Reviewed-By: Harshitha K P [email protected]
[detached HEAD fc824c4410] doc: fix link
 Author: Marco Ippolito [email protected]
 Date: Sun Feb 12 16:25:32 2023 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
 Rebasing (5/6)
 Rebasing (6/6)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 doc: fix added in version
Co-authored-by: Antoine du Hamel [email protected]
 PR-URL: #46627
 Refs: #44378
 Reviewed-By: Robert Nagy [email protected]
 Reviewed-By: Antoine du Hamel [email protected]
 Reviewed-By: Paolo Insogna [email protected]
 Reviewed-By: Luigi Pinca [email protected]
 Reviewed-By: Harshitha K P [email protected]
[detached HEAD ed658f3d9b] doc: fix added in version
 Author: Marco Ippolito [email protected]
 Date: Sun Feb 12 17:52:44 2023 +0100
 1 file changed, 3 insertions(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/4177499146

@ShogunPandaShogunPanda added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 14, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 14, 2023
@nodejs-github-botnodejs-github-bot merged commit 1b87cb6 into nodejs:mainFeb 14, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 14, 2023

Landed in 1b87cb6

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@marco-ippolito@MylesBorins
doc: add response.strictContentLength to documentation
76f5ce5
PR-URL: #46627 Refs: #44378 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 19, 2023
Merged
MylesBorins pushed a commit that referenced this pull request Feb 20, 2023
@marco-ippolito@MylesBorins
doc: add response.strictContentLength to documentation
a0a6ee0
PR-URL: #46627 Refs: #44378 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@marco-ippolito@danielleadams
doc: add response.strictContentLength to documentation
3afbb92
PR-URL: #46627 Refs: #44378 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes

@lpincalpincalpinca approved these changes

@ronagronagronag approved these changes

@aduh95aduh95aduh95 approved these changes

@HarshithaKPHarshithaKPHarshithaKP approved these changes

+1 more reviewer

@aymen94aymen94aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@marco-ippolito@nodejs-github-bot@ShogunPanda@lpinca@ronag@aymen94@aduh95@HarshithaKP