test_runner: display skipped subtests in spec reporter output

[richiemccoll]

This PR highlights skipped tests when running with --test-reporter=spec.

At the moment this is using the same approach as the tap reporter which is to display the # SKIP message. I've also updated the icon/color in the spec style to visually indicate what tests are skipped.

Given the following block of tests, here are some before/after snippets to highlight the minor change.

const{ test, describe, it }=require('node:test');describe('parent block',()=>{it('child subtest 1 should run',()=>{console.log('running first');});it('child subtest 2 should not run',{skip: true},()=>{console.log('running second');});});test('parent block',async(t)=>{awaitt.test('child subtest 1 should run',()=>{console.log('running first');});awaitt.test('child subtest 2 should not run',{skip: true},()=>{console.log('running second');});});test('parent block three',(t)=>{t.skip('this is skipped');});

Before

▶ parent block ✔ child subtest 1 should run (1.365111ms) ✔ child subtest 2 should not run (0.08218ms) ▶ parent block (4.580764ms) ▶ parent block ✔ child subtest 1 should run (0.157236ms) ✔ child subtest 2 should not run (0.081149ms) ▶ parent block (0.634555ms) ✔ parent block three (0.119197ms) ℹ tests 3 ℹ pass 2 ℹ fail 0 ℹ cancelled 0 ℹ skipped 1 ℹ todo 0 

After

▶ parent block ✔ child subtest 1 should run (1.403468ms) ✔ child subtest 2 should not run (0.090423ms) # SKIP ▶ parent block (5.349161ms) ▶ parent block ✔ child subtest 1 should run (0.169557ms) ✔ child subtest 2 should not run (0.119462ms) # SKIP ▶ parent block (0.780943ms) ✔ parent block three (0.130612ms) # SKIP ℹ tests 3 ℹ pass 2 ℹ fail 0 ℹ cancelled 0 ℹ skipped 1 ℹ todo 0 ℹ duration_ms 11.546297 

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[MoLow]

I'd prefer a different color and symbol for skipped tests instead of adding more text, WDYT? I'v used an arrow, but also - can be okay.

[richiemccoll]

@MoLow Agree, although I do think having the text does help. I pushed a small adjustment. WDYT?

[cjihrig]

LGTM if @MoLow is ok with it.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49579/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49695/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49702/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49708/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/46651 ✔ Done loading data for nodejs/node/pull/46651 ----------------------------------- PR info ------------------------------------ Title test_runner: display skipped subtests in spec reporter output (#46651) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch richiemccoll:test-runner/skip-tests-spec-reporter -> nodejs:main Labels author ready, needs-ci, dont-land-on-v14.x, test_runner Commits 1 - test_runner: display skipped tests in spec reporter output Committers 1 - richiemccoll PR-URL: https://github.com/nodejs/node/pull/46651 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46651 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test_runner: display skipped tests in spec reporter output ℹ This PR was created on Tue, 14 Feb 2023 15:37:17 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46651#pullrequestreview-1299611688 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/46651#pullrequestreview-1300108084 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-02-18T20:42:36Z: https://ci.nodejs.org/job/node-test-pull-request/49708/ - Querying data for job/node-test-pull-request/49708/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4213293471

[nodejs-github-bot]

Landed in 261bf96