assert: remove deprecated getFunction() usage#46661
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The method is meant to be removed by the V8 team. It is not a critical functionality that is removed, therefore no alternative is checked for either. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9421 Signed-off-by: Ruben Bridgewater <[email protected]>
nodejs-github-bot added assert 
joyeecheung approved these changes Feb 15, 2023
targos approved these changes Feb 15, 2023
VoltrexKeyva approved these changes Feb 15, 2023
ryzokuken approved these changes Feb 15, 2023
cjihrig approved these changes Feb 15, 2023
aduh95 added the author ready 
lpinca approved these changes Feb 16, 2023
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Feb 16, 2023
Collaborator
nodejs-github-bot commented Feb 17, 2023
Collaborator
nodejs-github-bot commented Feb 17, 2023
Collaborator
nodejs-github-bot commented Feb 17, 2023
Collaborator
nodejs-github-bot commented Feb 17, 2023
Collaborator
nodejs-github-bot commented Feb 17, 2023
32 tasks
Collaborator
nodejs-github-bot commented Feb 18, 2023
Collaborator
nodejs-github-bot commented Feb 18, 2023
BridgeAR added the commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Feb 18, 2023
Commit Queue failed- Loading data for nodejs/node/pull/46661 ✔ Done loading data for nodejs/node/pull/46661 ----------------------------------- PR info ------------------------------------ Title assert: remove deprecated getFunction() usage (#46661) Author Ruben Bridgewater (@BridgeAR) Branch BridgeAR:remove-getfunction -> nodejs:main Labels assert, author ready, needs-ci Commits 1 - assert: remove deprecated getFunction() usage Committers 1 - Ruben Bridgewater PR-URL: https://github.com/nodejs/node/pull/46661 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9421 Reviewed-By: Joyee Cheung Reviewed-By: Michaël Zasso Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Ujjwal Sharma Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46661 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9421 Reviewed-By: Joyee Cheung Reviewed-By: Michaël Zasso Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Ujjwal Sharma Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 14 Feb 2023 23:09:25 GMT ✔ Approvals: 6 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/46661#pullrequestreview-1298663890 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/46661#pullrequestreview-1298943870 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/46661#pullrequestreview-1299171916 ✔ - Ujjwal Sharma (@ryzokuken): https://github.com/nodejs/node/pull/46661#pullrequestreview-1299582281 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46661#pullrequestreview-1299620087 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46661#pullrequestreview-1302217081 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2023-02-18T03:17:01Z: https://ci.nodejs.org/job/node-test-pull-request/49673/ - Querying data for job/node-test-pull-request/49673/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4210382412 |
21 tasks
BridgeAR added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 19, 2023
Commit Queue failed- Loading data for nodejs/node/pull/46661 ✔ Done loading data for nodejs/node/pull/46661 ----------------------------------- PR info ------------------------------------ Title assert: remove deprecated getFunction() usage (#46661) Author Ruben Bridgewater (@BridgeAR) Branch BridgeAR:remove-getfunction -> nodejs:main Labels assert, author ready, needs-ci Commits 1 - assert: remove deprecated getFunction() usage Committers 1 - Ruben Bridgewater PR-URL: https://github.com/nodejs/node/pull/46661 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9421 Reviewed-By: Joyee Cheung Reviewed-By: Michaël Zasso Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Ujjwal Sharma Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46661 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9421 Reviewed-By: Joyee Cheung Reviewed-By: Michaël Zasso Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Ujjwal Sharma Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 14 Feb 2023 23:09:25 GMT ✔ Approvals: 6 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/46661#pullrequestreview-1298663890 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/46661#pullrequestreview-1298943870 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/46661#pullrequestreview-1299171916 ✔ - Ujjwal Sharma (@ryzokuken): https://github.com/nodejs/node/pull/46661#pullrequestreview-1299582281 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46661#pullrequestreview-1299620087 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46661#pullrequestreview-1302217081 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2023-02-18T08:38:53Z: https://ci.nodejs.org/job/node-test-pull-request/49673/ - Querying data for job/node-test-pull-request/49673/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4218112584 |
nodejs-github-bot added the commit-queue-failed 
MemberAuthor
BridgeAR commented Feb 19, 2023
Is there maybe an issue with the commit queue? The CI seems green? |
jasnell approved these changes Feb 20, 2023
Member
richardlau commented Feb 20, 2023
https://github.com/nodejs/node/actions/runs/4178911522/jobs/7246072143 has failed. |
MemberAuthor
BridgeAR commented Feb 20, 2023
Ah, I did not know that we checked for the github ones as well and did not read the message close enough ad it seems. |
BridgeAR added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 20, 2023
Landed in 43c380e |
targos pushed a commit that referenced this pull request Mar 13, 2023
The method is meant to be removed by the V8 team. It is not a critical functionality that is removed, therefore no alternative is checked for either. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9421 Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #46661 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
The method is meant to be removed by the V8 team. It is not a critical functionality that is removed, therefore no alternative is checked for either. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9421 Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #46661 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method is meant to be removed by the V8 team. It is not a critical functionality that is removed, therefore no alternative is checked for either.
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9421
@nodejs/v8 PTAL