debugger: add trailing commas in source files#46714
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added debugger 
cola119 approved these changes Feb 18, 2023
debadree25 approved these changes Feb 18, 2023
RaisinTen approved these changes Feb 18, 2023
aduh95 added author ready 
MoLow approved these changes Feb 18, 2023
jasnell approved these changes Feb 20, 2023
debadree25 added the commit-queue nodejs-github-bot added commit-queue-failed 
Collaborator
nodejs-github-bot commented Feb 21, 2023
Commit Queue failed- Loading data for nodejs/node/pull/46714 ✔ Done loading data for nodejs/node/pull/46714 ----------------------------------- PR info ------------------------------------ Title debugger: add trailing commas in source files (#46714) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:dangle-debugger -> nodejs:main Labels author ready, debugger Commits 1 - debugger: add trailing commas in source files Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/46714 Reviewed-By: Kohei Ueno Reviewed-By: Debadree Chatterjee Reviewed-By: Darshan Sen Reviewed-By: Moshe Atlow Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46714 Reviewed-By: Kohei Ueno Reviewed-By: Debadree Chatterjee Reviewed-By: Darshan Sen Reviewed-By: Moshe Atlow Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 18 Feb 2023 11:17:39 GMT ✔ Approvals: 5 ✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/46714#pullrequestreview-1304591415 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/46714#pullrequestreview-1304592916 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/46714#pullrequestreview-1304593263 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/46714#pullrequestreview-1304613663 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/46714#pullrequestreview-1304927164 ⚠ This PR has conflicts that must be resolved ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4236040765 |
PR-URL: nodejs#46714 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
ContributorAuthor
aduh95 commented Feb 22, 2023
Landed in 655b070 |
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46714 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46714 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.