Revert "src: let http2 streams end after session close"

[Trott]

This is #46249 with a lint fix.

[nodejs-github-bot]

Review requested:

• @nodejs/http2
• @nodejs/net

[github-actions]

Fast-track has been requested by @Trott. Please 👍 to approve.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49730/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49767/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49806/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/46721 ✔ Done loading data for nodejs/node/pull/46721 ----------------------------------- PR info ------------------------------------ Title Revert "src: let http2 streams end after session close" (#46721) Author Rich Trott (@Trott) Branch Trott:revert-it -> nodejs:main Labels c++, http2, fast-track, needs-ci, commit-queue-squash Commits 1 - Revert "src: let http2 streams end after session close" Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/46721 Reviewed-By: Colin Ihrig Reviewed-By: Debadree Chatterjee Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46721 Reviewed-By: Colin Ihrig Reviewed-By: Debadree Chatterjee Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - Revert "src: let http2 streams end after session close" ℹ This PR was created on Sat, 18 Feb 2023 19:29:56 GMT ✔ Approvals: 3 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46721#pullrequestreview-1304660204 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/46721#pullrequestreview-1304662808 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46721#pullrequestreview-1304733387 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-02-21T09:47:09Z: https://ci.nodejs.org/job/node-test-pull-request/49823/ - Querying data for job/node-test-pull-request/49823/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4232348563

[nodejs-github-bot]

Landed in d1b29b4

[Trott]

The commit authorship was preserved (as being authored by @santigimeno) in the PR here but it seems like the tooling changed the authorship when landing. (Maybe there's something in there that uses the gh CLI and passes the PR author in as the commit author? Totally guessing, though.) @nodejs/github-bot

[richardlau]

The commit authorship was preserved (as being authored by @santigimeno) in the PR here but it seems like the tooling changed the authorship when landing. (Maybe there's something in there that uses the gh CLI and passes the PR author in as the commit author? Totally guessing, though.) @nodejs/github-bot

I think we're going down this path

node/tools/actions/commit-queue.sh

Lines 84 to 105 in 7dede32

	# If there's only one commit, we can use the Squash and Merge feature from GitHub.
	# TODO: use `gh pr merge` when the GitHub CLI allows to customize the commit title (https://github.com/cli/cli/issues/1023).
	commit_title=$(git log -1 --pretty='format:%s')
	commit_body=$(git log -1 --pretty='format:%b')
	commit_head=$(grep 'Fetched commits as' output | cut -d. -f3 | xargs git rev-parse)
	jq -n \
	--arg title "${commit_title}" \
	--arg body "${commit_body}" \
	--arg head "${commit_head}" \
	'{merge_method:"squash",commit_title:$title,commit_message:$body,sha:$head}'> output.json
	cat output.json
	if! gh api -X PUT "repos/${OWNER}/${REPOSITORY}/pulls/${pr}/merge" --input output.json > output;then
	commit_queue_failed "$pr"
	continue
	fi
	cat output
	if! commits="$(jq -r 'if .merged then .sha else error("not merged") end'< output)";then
	commit_queue_failed "$pr"
	continue
	fi
	rm output.json

but it's not obvious to me that we're passing in an author -- perhaps it's a side effect of the "squash" feature?