Skip to content

Conversation

@MylesBorins
Copy link
Contributor

2023-02-21, Version 18.14.2 'Hydrogen' (LTS), @MylesBorins

Notable Changes

Commits

targosand others added 5 commits February 16, 2023 18:21
Refs: v8/v8@10.2.154.23...10.2.154.26 PR-URL: #46446 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
The `snapshot.blob` file landed while backporting 2c0f7d4 in the v18.x release line, but is not required Fixes: #46133 PR-URL: #46626 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #46353 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #46673 Reviewed-By: Luke Karrys <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #46711 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@nodejs-github-botnodejs-github-bot added dont-land-on-v14.x fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Feb 18, 2023
@github-actions

This comment was marked as outdated.

@MylesBorinsMylesBorins added request-ci Add this label to start a Jenkins CI on a PR. and removed fast-track PRs that do not need to wait for 48 hours to land. dont-land-on-v14.x labels Feb 18, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 18, 2023

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95
Copy link
Contributor

The commit message of a1a9d91 says "PR-URL: TODO", this would need to be amended I think.

Notable changes: deps: * upgrade npm to 9.5.0 (npm team) #46673 PR-URL: #46724
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@juanarboljuanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
ContributorAuthor

@MylesBorins
Copy link
ContributorAuthor

Tests are all green and nothing looks odd in CITGM. I'll do one last review of CITGM tomorrow before promoting the release.

@VoltrexKeyvaVoltrexKeyva added release Issues and PRs related to Node.js releases. and removed meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. labels Feb 21, 2023
@MylesBorins
Copy link
ContributorAuthor

There is a newish failure with torrent-stream on certain *nix boxes but it is failing on 18.14.1 and on 18.4.0

I'm going to move forward with the release

MylesBorins added a commit that referenced this pull request Feb 21, 2023
@MylesBorinsMylesBorins merged commit 4df0001 into v18.xFeb 21, 2023
@MylesBorinsMylesBorins deleted the v18.14.2-proposal branch February 21, 2023 18:10
MylesBorins added a commit that referenced this pull request Feb 21, 2023
Notable changes: deps: * upgrade npm to 9.5.0 (npm team) #46673 PR-URL: #46724
MylesBorins added a commit to nodejs/nodejs.org that referenced this pull request Feb 21, 2023
Trott pushed a commit to nodejs/nodejs.org that referenced this pull request Feb 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.releaseIssues and PRs related to Node.js releases.v18.xIssues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11 participants

@MylesBorins@nodejs-github-bot@aduh95@mcollina@ruyadorno@targos@BethGriggs@juanarbol@VoltrexKeyva@npm-cli-bot