test: fix flaky test-watch-mode-files_watcher#46738
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
MoLow added the flaky-test 
cjihrig approved these changes Feb 19, 2023
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
LGTM. Can you try running a stress test as well. Oh, and fiels -> files in the commit message.
MemberAuthor
MoLow commented Feb 19, 2023
The issue was reproduced pretty easily on my local machine so I made sure running 1000 times does not reproduce the issue |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Feb 19, 2023
24 tasks
debadree25 approved these changes Feb 20, 2023
Member
debadree25 left a comment
debadree25 left a comment There was a problem hiding this comment.
Tested, no longer reproduces on my machine too!
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Feb 20, 2023
MoLow added the commit-queue 
anonrig approved these changes Feb 20, 2023
Contributor
Fast-track has been requested by @anonrig. Please 👍 to approve. |
Member
richardlau commented Feb 20, 2023
I'd prefer if the typo in the commit message that Colin previously pointed out was fixed. |
nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Feb 20, 2023
Commit Queue failed- Loading data for nodejs/node/pull/46738 ✔ Done loading data for nodejs/node/pull/46738 ----------------------------------- PR info ------------------------------------ Title test: fix flaky test-watch-mode-fiels_watcher (#46738) Author Moshe Atlow (@MoLow) Branch MoLow:fix-flaky-test-watch-mode-files-watcher -> nodejs:main Labels test, flaky-test, fast-track, needs-ci Commits 1 - test: fix flaky test-watch-mode-fiels_watcher Committers 1 - Moshe Atlow PR-URL: https://github.com/nodejs/node/pull/46738 Reviewed-By: Colin Ihrig Reviewed-By: Debadree Chatterjee Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46738 Reviewed-By: Colin Ihrig Reviewed-By: Debadree Chatterjee Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 19 Feb 2023 19:53:30 GMT ✔ Approvals: 3 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46738#pullrequestreview-1304880465 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/46738#pullrequestreview-1305321785 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46738#pullrequestreview-1306348044 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least one collaborator's approval (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-02-20T10:21:32Z: https://ci.nodejs.org/job/node-test-pull-request/49774/ - Querying data for job/node-test-pull-request/49774/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4227200793 |
26 tasks
MoLowforce-pushed the fix-flaky-test-watch-mode-files-watcher branch from 28d21eb to 6853faaCompareMoLow added request-ci MoLow changed the title github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Feb 21, 2023
Collaborator
nodejs-github-bot commented Feb 21, 2023
Collaborator
nodejs-github-bot commented Feb 21, 2023
Collaborator
nodejs-github-bot commented Feb 21, 2023
MoLow added the commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Feb 21, 2023
Commit Queue failed- Loading data for nodejs/node/pull/46738 ✔ Done loading data for nodejs/node/pull/46738 ----------------------------------- PR info ------------------------------------ Title test: fix flaky test-watch-mode-files_watcher (#46738) Author Moshe Atlow (@MoLow) Branch MoLow:fix-flaky-test-watch-mode-files-watcher -> nodejs:main Labels test, flaky-test, fast-track, needs-ci Commits 1 - test: fix flaky test-watch-mode-files_watcher Committers 1 - Moshe Atlow PR-URL: https://github.com/nodejs/node/pull/46738 Reviewed-By: Colin Ihrig Reviewed-By: Debadree Chatterjee Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46738 Reviewed-By: Colin Ihrig Reviewed-By: Debadree Chatterjee Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test: fix flaky test-watch-mode-files_watcher ℹ This PR was created on Sun, 19 Feb 2023 19:53:30 GMT ✔ Approvals: 3 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46738#pullrequestreview-1304880465 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/46738#pullrequestreview-1305321785 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46738#pullrequestreview-1306348044 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-02-21T10:14:17Z: https://ci.nodejs.org/job/node-test-pull-request/49826/ - Querying data for job/node-test-pull-request/49826/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4232081092 |
MoLow added a commit that referenced this pull request Feb 21, 2023
PR-URL: #46738 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
MemberAuthor
MoLow commented Feb 21, 2023
Landed in 254574e |
This was referenced Feb 22, 2023
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46738 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46738 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#46729