assert: fix exception message for assert(0) on try catch block#46760
+78 −19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added assert 
BridgeAR approved these changes Feb 22, 2023
lib/assert.js Outdated
| functionparseCode(code,offset){ | ||
| // Lazy load acorn. | ||
| if(parseExpressionAt===undefined){ | ||
| if(parseExpressionAt===undefined||tokenizer===undefined){ |
Member
There was a problem hiding this comment.
Suggested change
| if(parseExpressionAt===undefined||tokenizer===undefined){ | |
| if(parseExpressionAt===undefined){ |
The second condition is not needed due to the tokenizer and parseExpressionAt being defined at the same moment.
ContributorAuthor
There was a problem hiding this comment.
@BridgeAR
Thanks for your feedback.
I see. I will revert this conditional expression back to the previous one.
lib/assert.js Outdated
| // expression is bigger than the provided buffer. | ||
| // eslint-disable-next-line no-throw-literal | ||
| thrownull; | ||
| if(node&&node.node.end>=offset){ |
Member
There was a problem hiding this comment.
Suggested change
| if(node&&node.node.end>=offset){ | |
| if(node?.node.end>=offset){ |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Feb 22, 2023
aduh95 reviewed Feb 22, 2023
Uh oh!
There was an error while loading. Please reload this page.
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Feb 24, 2023
cola119 approved these changes Feb 24, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
BridgeAR approved these changes Feb 25, 2023
BridgeAR added author ready github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Feb 25, 2023
aduh95 added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 26, 2023
Landed in 3c0131a |
targos pushed a commit that referenced this pull request Mar 13, 2023
Fixes: #30872 PR-URL: #46760 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Kohei Ueno <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
Fixes: #30872 PR-URL: #46760 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Kohei Ueno <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
Fixes: #30872 PR-URL: #46760 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Kohei Ueno <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #30872