Skip to content

Conversation

@Trott
Copy link
Member

@cola119closed#43018, probably because it had sat for so long without action. I think we should land it. Can folks please take a look? @nodejs/diagnostics

@nodejs-github-botnodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. doc Issues and PRs related to the documentations. labels Feb 22, 2023
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 22, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

Copy link
Member

@cola119cola119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your support on my previous pull request.

PR-URL: nodejs#46787 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@aduh95
Copy link
Contributor

aduh95 commented Feb 23, 2023

Landed in 5c7b81d (since the commit was authored by @cola119, I've put @Trott in the list of reviewers instead of him as Rich approved the original PR)

@aduh95aduh95 merged commit 5c7b81d into nodejs:mainFeb 23, 2023
@TrottTrott deleted the doc-update branch February 24, 2023 14:43
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46787 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@targostargos mentioned this pull request Mar 14, 2023
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46787 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debuggerIssues and PRs related to the debugger subsystem.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@aduh95@cola119@tony-go@RafaelGSS@nodejs-github-bot