test: stop faking performance idlharness#46794
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
legendecas approved these changes Feb 23, 2023
panva added author ready 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Feb 23, 2023
Collaborator
nodejs-github-bot commented Feb 23, 2023
25 tasks
jasnell approved these changes Feb 24, 2023
Collaborator
nodejs-github-bot commented Feb 24, 2023
targos approved these changes Feb 24, 2023
panva added the commit-queue 28 tasks
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 25, 2023
Landed in f359614 |
This was referenced Feb 26, 2023
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46794 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Contributor
danielleadams commented Jul 2, 2023
Pulling this into v18.x-staging broke the test suite, so this needs a backport. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is faking global attribute getters just for the sake of passing WPTs.