lib: fix DOMException property descriptors after being lazy loaded#46799
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Feb 23, 2023
Review requested:
|
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Feb 23, 2023
jasnell approved these changes Feb 24, 2023
panva added the author ready 
legendecas approved these changes Feb 24, 2023
panva added the commit-queue 
joyeecheung approved these changes Feb 24, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Joyee Cheung <[email protected]>
panva added commit-queue-squash github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Feb 24, 2023
tniessen approved these changes Feb 24, 2023
joyeecheung approved these changes Feb 24, 2023
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 25, 2023
Landed in f85113b |
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46799 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
PR-URL: #46799 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Contributor
danielleadams commented Apr 11, 2023
@panva this also broke builds in the v18.x-staging branch. Could you open a backport PR? Thank you |
MemberAuthor
panva commented Apr 11, 2023
Backport depends on #46425 |
targos pushed a commit that referenced this pull request Nov 10, 2023
PR-URL: #46799 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#46799 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#46799 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DOMException property descriptors after they being lazy loaded the first time.