Skip to content

Conversation

@joyeecheung
Copy link
Member

I also created the single-executable label -> (hopefully there's no objection to that ;))

@joyeecheungjoyeecheung added the single-executable Issues and PRs related to single-executable applications label Mar 8, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 8, 2023
@RaisinTen
Copy link
Member

Also, cc @nodejs/single-executable

Copy link
Member

@tony-gotony-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ^^

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 9, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 10, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/47004 ✔ Done loading data for nodejs/node/pull/47004 ----------------------------------- PR info ------------------------------------ Title meta: add single-executable labels and code owners (#47004) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:sea-pr -> nodejs:main Labels meta, author ready, single-executable Commits 2 - meta: add single-executable labels and code owners - fixup! meta: add single-executable labels and code owners #47004 Committers 2 - Joyee Cheung - GitHub PR-URL: https://github.com/nodejs/node/pull/47004 Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47004 Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 08 Mar 2023 00:27:16 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/47004#pullrequestreview-1330210062 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/47004#pullrequestreview-1332078736 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47004 From https://github.com/nodejs/node * branch refs/pull/47004/merge -> FETCH_HEAD ✔ Fetched commits as bcebb914f59e..d20d6430f6d7 -------------------------------------------------------------------------------- [main e327777f87] meta: add single-executable labels and code owners Author: Joyee Cheung Date: Tue Mar 7 23:27:56 2023 +0100 2 files changed, 4 insertions(+) [main d6b674b7ea] fixup! meta: add single-executable labels and code owners #47004 Author: Joyee Cheung Date: Thu Mar 9 11:38:10 2023 +0100 1 file changed, 7 insertions(+) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) 

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
meta: add single-executable labels and code owners

PR-URL: #47004
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Darshan Sen [email protected]

[detached HEAD 28bf21397d] meta: add single-executable labels and code owners
Author: Joyee Cheung [email protected]
Date: Tue Mar 7 23:27:56 2023 +0100
2 files changed, 4 insertions(+)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup! meta: add single-executable labels and code owners #47004

Co-authored-by: Darshan Sen [email protected]
PR-URL: #47004
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Darshan Sen [email protected]

[detached HEAD ec0a12cc2a] fixup! meta: add single-executable labels and code owners #47004
Author: Joyee Cheung [email protected]
Date: Thu Mar 9 11:38:10 2023 +0100
1 file changed, 7 insertions(+)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/4380167036

@joyeecheungjoyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 10, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 10, 2023
@nodejs-github-botnodejs-github-bot merged commit 1ccc8cc into nodejs:mainMar 10, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 1ccc8cc

targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #47004 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
PR-URL: #47004 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@targostargos mentioned this pull request Mar 14, 2023
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #47004 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.metaIssues and PRs related to the general management of the project.single-executableIssues and PRs related to single-executable applications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@joyeecheung@nodejs-github-bot@RaisinTen@aduh95@tony-go