net: fix setting of value in 'setDefaultAutoSelectFamilyAttemptTimeout'#47012
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Document describes that the value have to be 10 if passed value to `setDefaultAutoSelectFamilyAttemptTimeout` is less than 10. So need to use 10 for 'if' statement and fix typo in document. Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#netsetdefaultautoselectfamilyattempttimeoutvalue
Collaborator
nodejs-github-bot commented Mar 8, 2023
Review requested:
|
nodejs-github-bot added needs-ci 
ShogunPanda approved these changes Mar 8, 2023
Contributor
ShogunPanda left a comment
ShogunPanda left a comment There was a problem hiding this comment.
Yes, it is absolutely right. Thanks!
deokjinkim added request-ci 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Mar 8, 2023
anonrig approved these changes Mar 8, 2023
Collaborator
nodejs-github-bot commented Mar 9, 2023
Collaborator
nodejs-github-bot commented Mar 9, 2023
JungMinu approved these changes Mar 9, 2023
deokjinkim added the commit-queue anonrig approved these changes Mar 9, 2023
mcollina added request-ci nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Mar 10, 2023
Landed in b0d31bb |
This was referenced Mar 11, 2023
targos pushed a commit that referenced this pull request Mar 13, 2023
Document describes that the value have to be 10 if passed value to `setDefaultAutoSelectFamilyAttemptTimeout` is less than 10. So need to use 10 for 'if' statement and fix typo in document. Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#netsetdefaultautoselectfamilyattempttimeoutvalue PR-URL: #47012 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
24 tasks
targos pushed a commit that referenced this pull request Mar 14, 2023
Document describes that the value have to be 10 if passed value to `setDefaultAutoSelectFamilyAttemptTimeout` is less than 10. So need to use 10 for 'if' statement and fix typo in document. Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#netsetdefaultautoselectfamilyattempttimeoutvalue PR-URL: #47012 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Contributor
danielleadams commented Apr 11, 2023
@deokjinkim this broke the tests when landing in v18.x-staging. Do you mind opening a backport PR? |
ContributorAuthor
deokjinkim commented Apr 11, 2023
@danielleadams This depends on #45777, but it's still blocked. |
targos pushed a commit that referenced this pull request Nov 10, 2023
Document describes that the value have to be 10 if passed value to `setDefaultAutoSelectFamilyAttemptTimeout` is less than 10. So need to use 10 for 'if' statement and fix typo in document. Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#netsetdefaultautoselectfamilyattempttimeoutvalue PR-URL: #47012 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Document describes that the value have to be 10 if passed value to `setDefaultAutoSelectFamilyAttemptTimeout` is less than 10. So need to use 10 for 'if' statement and fix typo in document. Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#netsetdefaultautoselectfamilyattempttimeoutvalue PR-URL: nodejs/node#47012 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Document describes that the value have to be 10 if passed value to `setDefaultAutoSelectFamilyAttemptTimeout` is less than 10. So need to use 10 for 'if' statement and fix typo in document. Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#netsetdefaultautoselectfamilyattempttimeoutvalue PR-URL: nodejs/node#47012 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document describes that the value have to be 10 if passed value to
setDefaultAutoSelectFamilyAttemptTimeoutis less than 10. So need to use 10 for 'if' statement and fix typo in document.Refs: https://github.com/nodejs/node/blob/main/doc/api/net.md#netsetdefaultautoselectfamilyattempttimeoutvalue