doc,test: extend the list of platforms supported by single-executables#47026
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Now that nodejs#46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test. Signed-off-by: Darshan Sen <[email protected]>
RaisinTen added the single-executable 
Collaborator
nodejs-github-bot commented Mar 9, 2023
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
targos reviewed Mar 9, 2023
Uh oh!
There was an error while loading. Please reload this page.
Refs: nodejs#47026 (comment) Signed-off-by: Darshan Sen <[email protected]>
tony-go approved these changes Mar 9, 2023
Uh oh!
There was an error while loading. Please reload this page.
Refs: nodejs#47026 (comment) Co-authored-by: Tony Gorez <[email protected]>
debadree25 approved these changes Mar 9, 2023
Member
debadree25 commented Mar 9, 2023
(unrelated) Are there any tracking issues for the failures in these different platforms? would love to try my hand 😅 |
cjihrig approved these changes Mar 9, 2023
MemberAuthor
RaisinTen commented Mar 10, 2023
I haven't spent time investigating the remaining failures to come up with issues that are descriptive enough yet, maybe you could help out with that? |
RaisinTen added the author ready This comment was marked as outdated.
This comment was marked as outdated.
Member
debadree25 commented Mar 10, 2023
Best way to reproduce these locally? using a vm? if yes any recommendations on that? |
MemberAuthor
RaisinTen commented Mar 10, 2023
I normally use Parallels if I have to use a VM. If an issue still doesn't repro there, we can request access to a system in the build repo like I did in nodejs/build#3207. |
aymen94 approved these changes Mar 10, 2023
RaisinTen added request-ci 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Mar 11, 2023
RaisinTen added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Mar 11, 2023
Landed in 86c831f |
targos pushed a commit that referenced this pull request Mar 13, 2023
Now that #46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #47026 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
Now that #46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #47026 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Contributor
danielleadams commented Apr 4, 2023
This is blocked by #45038 |
targos pushed a commit that referenced this pull request Nov 10, 2023
Now that #46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #47026 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Now that nodejs/node#46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test. Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs/node#47026 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Now that nodejs/node#46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test. Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs/node#47026 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test.
(Initially tested this in #46868)
cc @nodejs/single-executable