doc: update incorrect links#47085
doc: update incorrect links #47085
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Mar 14, 2023
Review requested:
|
nodejs-github-bot added build 
deokjinkim commented Mar 24, 2023
@noel046 Thank you for contribution. Commit title needs to be started with subsystem like |
deokjinkim commented Mar 25, 2023
@noel046 For now, PR title is only changed. But we need to change commit title(not PR of github) in git. |
Trott commented Mar 26, 2023
The merge commit will need to be removed too. I'll do that now and force push. |
Trottforce-pushed the Incorrect-links-#47070 branch from f9629a7 to b358df1Compare
Trott commented Apr 1, 2023
The CI failure is relevant. This breaks links in the single-page version of the doc. |
| [`'drain'`]: #event-drain | ||
| [`'end'`]: #event-end | ||
| [`'error'`]: #event-error_1 | ||
| [`'error'`]: #event-error-1 |
There was a problem hiding this comment.
The current anchor exists in our HTML docs. The new one does not. What is the motivation for this change? Is it to fix something in the GitHub markdown rendering of this doc?
There was a problem hiding this comment.
+1, on our tooling we replace dots with nothing and underscores with hyphens. You can see it here: https://github.com/nodejs/node/blob/main/tools/doc/html.mjs#L426 (We do the same on nodejs.dev here https://github.com/nodejs/nodejs.dev/blob/main/util-node/createSlug.js#L1)
mscdex commented Apr 7, 2023
Please also add a to the commit message. |
mscdex commented Apr 22, 2023
Can we get this merged soon? We've been getting more and more identical PRs for the same (or a subset of) changes. |
ovflowd commented Apr 22, 2023
@mscdex did the issues Trott and me mentioned get resolved? |
mscdex commented Apr 22, 2023
@ovflowd I don't know. However from my recollection we tend to give the first to submit a PR for a specific set of changes priority, but as this PR has been open for over a month with others willing to make the same changes, we need to decide whether to continue waiting or close this PR and give others a chance to make the changes needed. |
aduh95 commented Sep 20, 2023
Superseded by #48194. |
7 participants
Fixes: #47070