test: skip instantiateStreaming-bad-imports WPT#47292
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0.
nodejs-github-bot added needs-ci 
MemberAuthor
targos commented Mar 29, 2023
/cc @nodejs/v8-update @nodejs/tsc |
RafaelGSS approved these changes Mar 29, 2023
gengjiawen approved these changes Mar 29, 2023
targos added fast-track 
Contributor
Fast-track has been requested by @targos. Please 👍 to approve. |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Mar 29, 2023
debadree25 approved these changes Mar 29, 2023
Member
Is it flaky, or just out right failing/hanging to a point where you want to skip it everywhere? If just flaky, the flaky test names may just be added like so {"instantiateStreaming-bad-imports.any.js": {"fail": {"note": "You may leave an optional arbitrary note e.g. with TODOs","flaky": ["flaky test name"]}}}If it's hanging, we need to look into the running properly handling such cases. If you want to skip them on a particular build or configuration, there's no way to do that today, but we could revive #45826 (comment) to be able to do this type of skipping/flaky declaration. |
panva approved these changes Mar 29, 2023
panva added the author ready MemberAuthor
targos commented Mar 29, 2023
It is hanging but not 100% of the runs. Either it passes or it hangs. |
Member
panva commented Mar 29, 2023
Let's skip then but open an issue to investigate why the runner can't deal with it. |
tniessen approved these changes Mar 29, 2023
Member
We can open a revert PR after landing V8 update on main. |
RaisinTen approved these changes Mar 29, 2023
panva added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Mar 29, 2023
Landed in 3cf65bd |
This was referenced Mar 29, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47292 Refs: #46815 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47292 Refs: #46815 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47292 Refs: #46815 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47292 Refs: #46815 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.
Refs: #46815 and #47251