test: skip test-wasm-web-api on ARM#47299
Closed
+2 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0.
This was referenced Mar 29, 2023
targos added v8 engine 
panva approved these changes Mar 29, 2023
Member
panva commented Mar 29, 2023
Fast-track has been requested by @targos. Please 👍 to approve. |
Member
panva commented Mar 29, 2023
(actions has degraded performance at this time so might take a while for the bot comment to appear, when it does, remove it as CQ looks at the last matching comment in the PR) |
gengjiawen approved these changes Mar 29, 2023
tniessen approved these changes Mar 29, 2023
richardlau approved these changes Mar 29, 2023
cjihrig approved these changes Mar 29, 2023
lpinca approved these changes Mar 29, 2023
anonrig approved these changes Mar 29, 2023
targos added the commit-queue 
nodejs-github-bot added commit-queue-failed 
Collaborator
nodejs-github-bot commented Mar 30, 2023
Commit Queue failed- Loading data for nodejs/node/pull/47299 ✔ Done loading data for nodejs/node/pull/47299 ----------------------------------- PR info ------------------------------------ Title test: skip test-wasm-web-api on ARM (#47299) Author Michaël Zasso (@targos) Branch targos:wasm-web-api -> nodejs:main Labels v8 engine, test, arm, fast-track, wasm Commits 1 - test: skip test-wasm-web-api on ARM Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/47299 Refs: https://github.com/nodejs/node/pull/47251 Reviewed-By: Filip Skokan Reviewed-By: Jiawen Geng Reviewed-By: Tobias Nießen Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47299 Refs: https://github.com/nodejs/node/pull/47251 Reviewed-By: Filip Skokan Reviewed-By: Jiawen Geng Reviewed-By: Tobias Nießen Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 29 Mar 2023 15:30:45 GMT ✔ Approvals: 7 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363426574 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363467577 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363470733 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363548198 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363551730 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363700293 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363880905 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4561323427 |
targos added request-ci 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Mar 30, 2023
Collaborator
nodejs-github-bot commented Mar 30, 2023
Collaborator
nodejs-github-bot commented Mar 30, 2023
targos added the commit-queue nodejs-github-bot removed the commit-queue nodejs-github-bot added the commit-queue-failed Collaborator
nodejs-github-bot commented Mar 30, 2023
Commit Queue failed- Loading data for nodejs/node/pull/47299 ✔ Done loading data for nodejs/node/pull/47299 ----------------------------------- PR info ------------------------------------ Title test: skip test-wasm-web-api on ARM (#47299) Author Michaël Zasso (@targos) Branch targos:wasm-web-api -> nodejs:main Labels v8 engine, test, arm, fast-track, wasm Commits 1 - test: skip test-wasm-web-api on ARM Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/47299 Refs: https://github.com/nodejs/node/pull/47251 Reviewed-By: Filip Skokan Reviewed-By: Jiawen Geng Reviewed-By: Tobias Nießen Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47299 Refs: https://github.com/nodejs/node/pull/47251 Reviewed-By: Filip Skokan Reviewed-By: Jiawen Geng Reviewed-By: Tobias Nießen Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 29 Mar 2023 15:30:45 GMT ✔ Approvals: 7 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363426574 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363467577 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363470733 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363548198 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363551730 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363700293 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363880905 ℹ This PR is being fast-tracked ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-03-30T06:50:07Z: https://ci.nodejs.org/job/node-test-pull-request/50687/ - Querying data for job/node-test-pull-request/50687/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4563127960 |
MemberAuthor
targos commented Mar 30, 2023
Landed in 65b79ab |
targos added a commit that referenced this pull request Mar 30, 2023
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47299 Refs: #47251 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47299 Refs: #47251 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47299 Refs: #47251 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47299 Refs: #47251 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47299 Refs: #47251 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
richardlau added a commit to richardlau/node-1 that referenced this pull request Sep 29, 2023
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`. Update the status files for parallel and es-modules accordingly. Refs: nodejs#49869 Refs: nodejs#47299 Refs: nodejs#47297
nodejs-github-bot pushed a commit that referenced this pull request Sep 30, 2023
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`. Update the status files for parallel and es-modules accordingly. Refs: #49869 Refs: #47299 Refs: #47297 PR-URL: #49958 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
GeoffreyBooth pushed a commit to GeoffreyBooth/node that referenced this pull request Oct 1, 2023
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`. Update the status files for parallel and es-modules accordingly. Refs: nodejs#49869 Refs: nodejs#47299 Refs: nodejs#47297 PR-URL: nodejs#49958 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`. Update the status files for parallel and es-modules accordingly. Refs: nodejs#49869 Refs: nodejs#47299 Refs: nodejs#47297 PR-URL: nodejs#49958 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`. Update the status files for parallel and es-modules accordingly. Refs: #49869 Refs: #47299 Refs: #47297 PR-URL: #49958 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`. Update the status files for parallel and es-modules accordingly. Refs: nodejs#49869 Refs: nodejs#47299 Refs: nodejs#47297 PR-URL: nodejs#49958 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.
Refs: #47251