tools: automate uvwasi dependency update#47509
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented Apr 11, 2023
Review requested:
|
nodejs-github-bot added meta 
Uh oh!
There was an error while loading. Please reload this page.
| * Copy over the contents of `include` and `src` to the corresponding | ||
| directories. | ||
| * Check if any additional files have been added and need to be added |
There was a problem hiding this comment.
Is there any way to check this in the update script and to generate a warning/info message if there are new files found?
There was a problem hiding this comment.
That’s a valid point, maybe @marco-ippolito already faced something alike in other scripts, I'll ask him!
There was a problem hiding this comment.
this is the first attempt of automating gyp file update #47482, let's see how it goes and if its reliable we can add it to other dependencies.
For the time being I'd add a warn like:echo "Make sure to update the deps/uvwasi/uvwasi.gyp if any significant changes have occurred upstream" in the bash script
RafaelGSS commented Apr 13, 2023
cc: @nodejs/security-wg |
RafaelGSS added the commit-queue nodejs-github-bot removed the commit-queue nodejs-github-bot commented Apr 13, 2023
Landed in 5fa84e8 |
Refs: nodejs/security-wg#828 PR-URL: #47509 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Refs: nodejs/security-wg#828 PR-URL: #47509 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Refs: nodejs/security-wg#828 PR-URL: nodejs#47509 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
5 participants
Refs: nodejs/security-wg#828