src: replace static const string_view by static constexpr#47524
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
lemire changed the title 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Apr 12, 2023
anonrig approved these changes Apr 12, 2023
MemberAuthor
lemire commented Apr 12, 2023
@anonrig This seems to make the wpt_tests fail. How is that possible? This PR should not change the result of the code. It is a very narrow change. |
Member
anonrig commented Apr 12, 2023
It might be flaky tests. I'll re-run the test suite. |
Collaborator
nodejs-github-bot commented Apr 12, 2023
36 tasks
Collaborator
nodejs-github-bot commented Apr 13, 2023
anonrig added the author ready Collaborator
nodejs-github-bot commented Apr 13, 2023
MemberAuthor
lemire commented Apr 13, 2023
It works now!!! And I did not change the code. |
33 tasks
tniessen changed the title 
jasnell approved these changes Apr 15, 2023
anonrig added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Apr 15, 2023
Landed in a777bbd |
targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47524 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47524 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47524 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is slightly better to use
static constexpr std::string_viewcompared tostatic const std::string_view. See https://lemire.me/blog/2023/04/12/consider-using-constexpr-static-function-variables-for-performance/ for details.It is a micro-optimization: you are unlikely to be able to measure the difference, but it should generate less bloat.