esm: propagate process.exit from the loader thread to the main thread#47548
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Apr 13, 2023
Review requested:
|
nodejs-github-bot added esm Uh oh!
There was an error while loading. Please reload this page.
GeoffreyBooth approved these changes Apr 14, 2023
aduh95 added author ready 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Apr 14, 2023
33 tasks
Collaborator
nodejs-github-bot commented Apr 15, 2023
Collaborator
nodejs-github-bot commented Apr 16, 2023
Collaborator
nodejs-github-bot commented Apr 17, 2023
35 tasks
Collaborator
nodejs-github-bot commented Apr 18, 2023
Collaborator
nodejs-github-bot commented Apr 18, 2023
Collaborator
nodejs-github-bot commented Apr 18, 2023
GeoffreyBooth added commit-queue-squash nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Apr 19, 2023
Landed in 2e0152c |
39 tasks
targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47548 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
PR-URL: nodejs#47548 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
targos pushed a commit that referenced this pull request Nov 23, 2023
PR-URL: #47548 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#47548 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#47548 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
process.exitfrom the loader used to exit the process, but now that loader code is executed on a different thread, we need to pass the information across thread to avoid leaving the main thread without a loader thread.