Skip to content

esm: initialize import.meta on eval#47551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Apr 19, 2023
Merged

esm: initialize import.meta on eval #47551

nodejs-github-bot merged 1 commit into from
Apr 19, 2023

Conversation

@aduh95
Copy link
Contributor

@aduh95aduh95 commented Apr 13, 2023

No description provided.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 13, 2023

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Apr 13, 2023
JakobJingleheimer
JakobJingleheimer reviewed Apr 13, 2023
View reviewed changes
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 14, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 14, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51269/

@github-actionsgithub-actionsbot mentioned this pull request Apr 15, 2023
Open
33 tasks
@github-actionsgithub-actionsbot mentioned this pull request Apr 18, 2023
Open
35 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51339/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51347/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51349/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 19, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51355/

@GeoffreyBoothGeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Apr 19, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2023
@nodejs-github-botnodejs-github-bot merged commit ee08c70 into nodejs:mainApr 19, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 19, 2023

Landed in ee08c70

@aduh95aduh95 deleted the import-meta-eval branch April 19, 2023 20:55
targos pushed a commit that referenced this pull request May 2, 2023
@aduh95@targos
esm: initialize import.meta on eval
c150976
PR-URL: #47551 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
@targostargos mentioned this pull request May 2, 2023
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95@targos
esm: initialize import.meta on eval
40fa6e4
PR-URL: nodejs#47551 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
@targostargos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95@targos
esm: initialize import.meta on eval
5de37a1
PR-URL: #47551 Backport-PR-URL: #50669 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: initialize import.meta on eval
562a477
PR-URL: nodejs/node#47551 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: initialize import.meta on eval
740eae8
PR-URL: nodejs/node#47551 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes

@guybedfordguybedfordguybedford approved these changes

@JakobJingleheimerJakobJingleheimerJakobJingleheimer approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.esmIssues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

ESM Loaders: Stable (CJS parity)

Development

Successfully merging this pull request may close these issues.

7 participants

@aduh95@nodejs-github-bot@GeoffreyBooth@guybedford@JakobJingleheimer@targos@danielleadams