Skip to content

test_runner: add testNamePatterns to run api#47628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atlowChemi wants to merge 1 commit into from
Closed

test_runner: add testNamePatterns to run api #47628

atlowChemi wants to merge 1 commit into from

Conversation

@atlowChemi
Copy link
Member

@atlowChemiatlowChemi commented Apr 19, 2023

Accept a testNamePatterns value in the run fn, and drill those patterns to the spawned processes.
Fixes: #46045

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 19, 2023

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Apr 19, 2023
@atlowChemiatlowChemiforce-pushed the test_runner--add-name-patterns-to-run-api branch from 3fb7c7e to c7c46e2CompareApril 19, 2023 22:34
ljharb
ljharb reviewed Apr 19, 2023
View reviewed changes
@atlowChemiatlowChemiforce-pushed the test_runner--add-name-patterns-to-run-api branch from c7c46e2 to fa9f118CompareApril 20, 2023 05:06
@atlowChemiatlowChemi marked this pull request as ready for review April 20, 2023 05:06
@atlowChemiatlowChemiforce-pushed the test_runner--add-name-patterns-to-run-api branch from fa9f118 to 72137fdCompareApril 20, 2023 08:36
MoLow
MoLow reviewed Apr 20, 2023
View reviewed changes
@atlowChemi
test_runner: add testNamePatterns to run api
dea6914
Accept a `testNamePatterns` value in the `run` fn, and drill those patterns to the spawned processes. Fixes: nodejs#46045
@atlowChemiatlowChemiforce-pushed the test_runner--add-name-patterns-to-run-api branch from 72137fd to dea6914CompareApril 20, 2023 15:59
@MoLowMoLow requested a review from benjamingrApril 21, 2023 10:11
@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51392/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 22, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51413/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 23, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51425/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 23, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51426/

@MoLowMoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 23, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 23, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 23, 2023

Commit Queue failed
- Loading data for nodejs/node/pull/47628 ✔ Done loading data for nodejs/node/pull/47628 ----------------------------------- PR info ------------------------------------ Title test_runner: add testNamePatterns to run api (#47628) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch atlowChemi:test_runner--add-name-patterns-to-run-api -> nodejs:main Labels author ready, needs-ci, dont-land-on-v14.x, test_runner Commits 1 - test_runner: add testNamePatterns to run api Committers 1 - atlowChemi PR-URL: https://github.com/nodejs/node/pull/47628 Fixes: https://github.com/nodejs/node/issues/46045 Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47628 Fixes: https://github.com/nodejs/node/issues/46045 Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 19 Apr 2023 22:29:54 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/47628#pullrequestreview-1394841197 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47628#pullrequestreview-1396865473 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-04-23T06:53:39Z: https://ci.nodejs.org/job/node-test-pull-request/51426/ - Querying data for job/node-test-pull-request/51426/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47628 From https://github.com/nodejs/node * branch refs/pull/47628/merge -> FETCH_HEAD ✔ Fetched commits as dbf71e509c72..dea691403b25 -------------------------------------------------------------------------------- [main 1735ca6b7d] test_runner: add testNamePatterns to run api Author: atlowChemi Date: Thu Apr 20 00:16:57 2023 +0200 4 files changed, 63 insertions(+), 7 deletions(-) create mode 100644 test/fixtures/test-runner/test/skip_by_name.cjs ✔ Patches applied -------------------------------------------------------------------------------- ✘ Git found no trailers in the original commit message, but 'Fixes: https://github.com/nodejs/node/issues/46045' is present and should be a trailer.
https://github.com/nodejs/node/actions/runs/4777711253

@MoLowMoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 23, 2023
@MoLow
Copy link
Member

MoLow commented Apr 23, 2023

Landed in c627969

@MoLowMoLow closed this Apr 23, 2023
@atlowChemiatlowChemi deleted the test_runner--add-name-patterns-to-run-api branch April 23, 2023 14:06
@benjamingr
Copy link
Member

benjamingr commented Apr 23, 2023

Looks like this has the wrong PR-URL @MoLow - either force-push a fix and let people know or go over releases it's in later and fix references?

@MoLow
Copy link
Member

MoLow commented Apr 23, 2023

@benjamingr it seems like there as been a commit pushed already

cjihrig referenced this pull request Apr 23, 2023
@atlowChemi@MoLow
test_runner: add testNamePatterns to run api
c627969
Accept a `testNamePatterns` value in the `run` fn, and drill those patterns to the spawned processes. PR-URL: #47648 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@atlowChemi
Copy link
MemberAuthor

atlowChemi commented Apr 23, 2023

@MoLow The issue was not auto-closed FYI

This was referenced Apr 24, 2023
Open
Open
Open
Open
@targostargos added the semver-minor PRs that contain new features and should be released in the next minor version. label May 2, 2023
targos added a commit that referenced this pull request May 3, 2023
@targos
2023-05-03, Version 20.1.0 (Current)
68ef4a6
Notable changes: assert: * deprecate `CallTracker` (Moshe Atlow) #47740 crypto: * update root certificates to NSS 3.89 (Node.js GitHub Bot) #47659 dns: * (SEMVER-MINOR) expose `getDefaultResultOrder` (btea) #46973 doc: * add KhafraDev to collaborators (Matthew Aitken) #47510 fs: * (SEMVER-MINOR) add `recursive` option to `readdir` and `opendir` (Ethan Arrowood) #41439 * (SEMVER-MINOR) add support for `mode` flag to specify the copy behavior of the `cp` methods (Tetsuharu Ohzeki) #47084 http: * (SEMVER-MINOR) add `highWaterMark` option `http.createServer` (HinataKah0) #47405 stream: * (SEMVER-MINOR) preserve object mode in `compose` (Raz Luvaton) #47413 test_runner: * (SEMVER-MINOR) add `testNamePatterns` to `run` API (Chemi Atlow) #47628 * (SEMVER-MINOR) execute `before` hook on test (Chemi Atlow) #47586 * (SEMVER-MINOR) support combining coverage reports (Colin Ihrig) #47686 wasi: * (SEMVER-MINOR) make `returnOnExit` true by default (Michael Dawson) #47390 PR-URL: #47820
@targostargos mentioned this pull request May 3, 2023
Merged
targos added a commit that referenced this pull request May 3, 2023
@targos
2023-05-03, Version 20.1.0 (Current)
c24a61b
Notable changes: assert: * deprecate `CallTracker` (Moshe Atlow) #47740 crypto: * update root certificates to NSS 3.89 (Node.js GitHub Bot) #47659 dns: * (SEMVER-MINOR) expose `getDefaultResultOrder` (btea) #46973 doc: * add KhafraDev to collaborators (Matthew Aitken) #47510 fs: * (SEMVER-MINOR) add `recursive` option to `readdir` and `opendir` (Ethan Arrowood) #41439 * (SEMVER-MINOR) add support for `mode` flag to specify the copy behavior of the `cp` methods (Tetsuharu Ohzeki) #47084 http: * (SEMVER-MINOR) add `highWaterMark` option `http.createServer` (HinataKah0) #47405 stream: * (SEMVER-MINOR) preserve object mode in `compose` (Raz Luvaton) #47413 test_runner: * (SEMVER-MINOR) add `testNamePatterns` to `run` API (Chemi Atlow) #47628 * (SEMVER-MINOR) execute `before` hook on test (Chemi Atlow) #47586 * (SEMVER-MINOR) support combining coverage reports (Colin Ihrig) #47686 wasi: * (SEMVER-MINOR) make `returnOnExit` true by default (Michael Dawson) #47390 PR-URL: #47820
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb left review comments

@benjamingrbenjamingrbenjamingr approved these changes

@MoLowMoLowMoLow approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.semver-minorPRs that contain new features and should be released in the next minor version.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support --test-name-pattern in run()

6 participants

@atlowChemi@nodejs-github-bot@MoLow@benjamingr@ljharb@targos