doc: add "building node with ninja" guide#4767
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Fishrock123 commented Jan 19, 2016
cc @nodejs/documentation |
chrisdickinson commented Jan 20, 2016
Thanks for PR'ing this in! The Docs WG is going to discuss next steps on adding guides in tomorrows meeting at 10AM PST; we'll take action on the PR shortly after that. |
There was a problem hiding this comment.
Throw in a newline after this so markdown knows it's a list. Same on line 11.
There was a problem hiding this comment.
Hmm, my preview works fine, maybe it's just github. Oh well.
bengl commented Jan 20, 2016
Please word-wrap at 80 characters, as per https://github.com/nodejs/docs/blob/master/STYLE-GUIDE.md |
Fishrock123 commented Jan 22, 2016
@bengl 80 characters does not work for lists. The list will force a newline. :/ |
chrisdickinson commented Jan 22, 2016
@Fishrock123 I don't think that's so — for example:
Source: * Hello there. I am wrapped. * I am wrapped too But it's okay.Edit, if that's too ugly:
* Hello there. I am wrapped. * I am wrapped too But it's okay.Will work too! |
Fishrock123 commented Jan 22, 2016
@chrisdickinson I don't think this is necessarily consistent between parsers/renderers then:
(Atom's markdown preview) |
Fishrock123 commented Jan 22, 2016
@bengl I consolidated the instructions into one list. :) |
jbergstroem commented Jan 22, 2016
@Fishrock123 you mention a few times how much faster it is -- out of curiosity, could you quantify it? |
Fishrock123 commented Jan 22, 2016
@jbergstroem you mean I'd say it's at least 40% faster |
jbergstroem commented Jan 22, 2016
@Fishrock123 so |
Fishrock123 commented Jan 22, 2016
@jbergstroem well, that's how much faster it feels so maybe it isn't idk. |
jbergstroem commented Jan 22, 2016
Just tested it locally:
|
Fishrock123 commented Jan 25, 2016
ping @bengl & @chrisdickinson |
bengl commented Jan 30, 2016
ok LGTM 👍 |
Fishrock123 commented Feb 8, 2016
@bengl Updated a bit (I wasn't comfortable with some statements), PTAL. @chrisdickinson I still haven't shortened the lines... do we need to take it back to the docs WG? My editor renderer does not render split lines very nicely. |
Fishrock123 commented Feb 22, 2016
I'm going to land this tomorrow (Tuesday) unless there is additional review. We can fix any problems with it after I guess. |
bengl commented Feb 22, 2016
Whoops, missed this. Yep, LGTM. |
Fishrock123 commented Feb 22, 2016
@chrisdickinson do doc wg members officially have sign-off rights for |
Qard commented Feb 22, 2016
LGTM too. 👍 |
PR-URL: nodejs#4767 Refs: nodejs/docs#38 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Stephan Belanger <[email protected]>
Fishrock123force-pushed the ninja-build-guide branch from 0d503d2 to 65c0febCompare
PR-URL: #4767 Refs: nodejs/docs#38 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Stephan Belanger <[email protected]>
PR-URL: #4767 Refs: nodejs/docs#38 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Stephan Belanger <[email protected]>
PR-URL: #4767 Refs: nodejs/docs#38 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Stephan Belanger <[email protected]>
PR-URL: #4767 Refs: nodejs/docs#38 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Stephan Belanger <[email protected]>
PR-URL: #4767 Refs: nodejs/docs#38 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Stephan Belanger <[email protected]>
10 participants
People always ask me about how to do this, and there's no good info about it really anywhere.
Moving from nodejs/docs#38