test: remove Object.observe from tests#4769
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
silverwind commented Jan 19, 2016
Do we know when v8 will drop it? |
silverwind added v8 engine 
Contributor
cjihrig commented Jan 19, 2016
LGTM if the CI is happy, although we should probably keep the tests as long as our V8 ships |
ContributorAuthor
vkurchatkin commented Jan 19, 2016
@cjihrig we could, but to tell the truth, it doesn't really add value in this particular case |
Contributor
silverwind commented Jan 19, 2016
Found it: https://groups.google.com/a/chromium.org/forum/#!topic/blink-reviews-bindings/vwyJiq5u38E
|
Contributor
mgol commented Jan 19, 2016
It says about deprecating, not dropping, though. |
Contributor
silverwind commented Jan 20, 2016
How about skipping the test if |
Contributor
cjihrig commented Jan 20, 2016
Is there any real rush to get rid of this? Is it hindering anything at all? |
Contributor
Fishrock123 commented Jan 20, 2016
@cjihrig It fails in Chakra because uh, Chakra doesn't have it since it's no-longer spec. |
Member
bnoordhuis commented Jan 20, 2016
LGTM. It's non-spec so let's get rid of it. |
Member
bnoordhuis commented Jan 20, 2016
Contributor
cjihrig commented Jan 20, 2016
Makes sense then. LGTM |
Contributor
mscdex commented Jan 20, 2016
LGTM assuming the two test failures on pi1 in CI are unrelated. |
Member
jasnell commented Jan 22, 2016
They appear to be unrelated. |
Contributor
silverwind commented Jan 27, 2016
Thanks! Landed in b4313cf. |
silverwind pushed a commit that referenced this pull request Jan 27, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Member
ChALkeR commented Jan 27, 2016
I was under an impression that they already did drop it, but it seems they re-enabled it again due to backwards compatibility with something. |
rvagg pushed a commit that referenced this pull request Jan 28, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 8, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (#4765) for obvious reason. PR-URL: #4769 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Testing this wasn't really useful, besides Object.observe is going to be deprecated. Also this test fails with Chakra (nodejs#4765) for obvious reason. PR-URL: nodejs#4769 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing this wasn't really useful, besides Object.observe is going to be deprecated.
Also this test fails with Chakra (#4765) for obvious reason.